From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.3658.1597348843360034665 for ; Thu, 13 Aug 2020 13:00:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T+9rPOYs; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597348842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Pd36C2fIGh13nBXViBgBzDWcNoyPUCVgxHZWeyExig=; b=T+9rPOYs909wfjwH3OUd3Br/C5lQnSz6W+F/Zhc5mJ0957I3TJP29jDuI0lpfLefU1bhzR Of5HQFw6uSIhLk+jnINcKEVYyyB5cum+CpLqehRmLkLHd3QZ85JF11zrJ0/IfiLISbW5KY Y+2EW+kCP6dKF+xiBSEpXqniORn9tRk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-bJfN_g2_OO-AMLLlj2lPbQ-1; Thu, 13 Aug 2020 16:00:31 -0400 X-MC-Unique: bJfN_g2_OO-AMLLlj2lPbQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7513518B6324; Thu, 13 Aug 2020 20:00:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-166.ams2.redhat.com [10.36.112.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id 697A95D9F3; Thu, 13 Aug 2020 20:00:29 +0000 (UTC) Subject: Re: [edk2-devel] [Patch ] Static IP based HTTP Support To: devel@edk2.groups.io, sivaramann@amiindia.co.in Cc: "liming.gao@intel.com" , "jiaxin.wu@intel.com" References: From: "Laszlo Ersek" Message-ID: Date: Thu, 13 Aug 2020 22:00:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hi, On 08/13/20 17:59, Sivaraman Nainar wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2888 > > *** NetworkPkg\HttpBootDxe\HttpBootClient.c 2020-05-07 22:54:46.000000000 +05-30 > --- NetworkPkg\HttpBootDxe\HttpBootClient.c 2020-08-09 21:03:01.000000000 +05-30 > *************** > *** 1,6 **** > --- 1,13 ---- > + //*********************************************************************** > + //* * > + //* Copyright (c) 1985-2020, American Megatrends International LLC. * > + //* * > + //* All rights reserved. Subject to AMI licensing agreement. * > + //* * > + //*********************************************************************** > /** @file > Implementation of the boot file download function. > > Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent this patch does not have a proper commit message, a proper Signed-off-by line, a proper subject line, and a proper diff format (it's not expressed as a unified diff). Please consult the following references: - official: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process - unofficial: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers I'd also think that the huge legal banner added at the top of the file is out of place. I think you can add a (C) notice (with the year 2020) near the existing copyright notices. However, the line "All rights reserved. Subject to AMI licensing agreement." is wrong; it conflicts with SPDX-License-Identifier: BSD-2-Clause-Patent Thanks, Laszlo