From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D8D22098C8AC for ; Fri, 3 Aug 2018 09:10:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA73D7A7EF; Fri, 3 Aug 2018 16:10:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-198.rdu2.redhat.com [10.10.120.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3CDED1CBBF; Fri, 3 Aug 2018 16:09:58 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Ruiyu Ni , Eric Dong , Liming Gao , Michael D Kinney , Jiaxin Wu , Jiewen Yao , Star Zeng , Jaben Carsey , Siyuan Fu , Chao Zhang , Fam Zheng , Paolo Bonzini References: <20180803121537.32123-1-lersek@redhat.com> Message-ID: Date: Fri, 3 Aug 2018 18:09:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180803121537.32123-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 03 Aug 2018 16:10:02 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 03 Aug 2018 16:10:02 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2 0/7] UefiLib: centralize OpenFileByDevicePath() and fix its bugs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 16:10:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/03/18 14:15, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: open_file_by_devpath_tiano_1008_v2 > > This is version 2 of the patch set that was originally posted at: > > https://lists.01.org/pipermail/edk2-devel/2018-July/027253.html > > for . > > Changes are noted on every patch. > > The cumulative code difference is very small (not counting the > FrameworkUefiLib copy of the function), so I'm including it here for > easier review: > >> [...] I should use this opportunity to highlight an awesome community feature from Paolo and Fam (CC'd): the patchew.org website has been tracking edk2 patch submissions for a while: https://patchew.org/ https://patchew.org/EDK2/ and now it offers side-by-side comparison between versions of the same patch set ("interdiff"). For example, the link for this (v2) series is: https://patchew.org/EDK2/20180803121537.32123-1-lersek@redhat.com/ and if you click the "Diff against v1" link, you get: https://patchew.org/EDK2/20180718205043.17574-1-lersek@redhat.com/diff/20180803121537.32123-1-lersek@redhat.com/ I recommend that all edk2 reviewers make use of this feature, for incrementally reviewing patch series. (This is another good reason for keeping the source code lines limited to 80 columns -- if you write 200 character long lines, you won't have a good time looking at side-by-side diffs!) Laszlo