From: Laszlo Ersek <lersek@redhat.com>
To: "Feng, YunhuaX" <yunhuax.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue
Date: Wed, 11 Apr 2018 09:57:54 +0200 [thread overview]
Message-ID: <a1436cc5-b4a0-9517-9359-9e1e69f77551@redhat.com> (raw)
In-Reply-To: <47C64442C08CCD4089DC43B6B5E46BC484BA94@shsmsx102.ccr.corp.intel.com>
Hello Yunhua,
On 04/10/18 03:09, Feng, YunhuaX wrote:
> Free DummyFileBuffer and set DummyFileBuffer to NULL.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
> ---
> BaseTools/Source/C/GenSec/GenSec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
can you please post patch sets with a cover letter, and with shallow
threading enabled?
The following three commands [1] should configure shallow threading
permanently:
git config format.coverletter true
git config sendemail.chainreplyto false
git config sendemail.thread true
Thank you,
Laszlo
[1]
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05
next prev parent reply other threads:[~2018-04-11 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 1:09 [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue Feng, YunhuaX
2018-04-11 6:33 ` Zhu, Yonghong
2018-04-11 7:57 ` Laszlo Ersek [this message]
2018-04-11 9:02 ` Laszlo Ersek
2018-04-11 14:27 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1436cc5-b4a0-9517-9359-9e1e69f77551@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox