Re: [PATCH 0/5] ArmVirtQemu: move to generic PciHostBridgeDxe

[Laszlo Ersek <lersek@redhat.com>]

On 08/22/16 02:35, Ard Biesheuvel wrote:
> Now that Laszlo's virtio-gpu-pci have removed the last remaining obstacle,
> we can get rid of the special PciHostBridgeDxe implementation in ArmVirtPkg,
> and move to the generic one. This will allow us to perform DMA above 4GB
> without bounce buffering, and use 64-bit MMIO BARs.
> 
> Patch #1 removes the linux,pci-probe-only override which does more harm than
> good now that we switched to virtio-gp-pci, which does not expose a raw
> framebuffer.
> 
> Patch #2 implements PciHostBridgeLib for platforms exposing a PCI host bridge
> using a pci-host-ecam-generic DT node.
> 
> Patch #3 switches to the generic PciHostBridgeDxe, with no change in
> functionality other than support for DMA above 4 GB without bounce buffering.
> 
> Patch #4 adds support for 64-bit MMIO BARs
> 
> Patch #5 removes the now obsolete PciHostBridgeDxe from ArmVirPkg.
> 
> Ard Biesheuvel (5):
>   ArmVirtPkg/PciHostBridgeDxe: don't set linux,pci-probe-only DT
>     property
>   ArmVirtPkg: implement FdtPciHostBridgeLib
>   ArmVirtPkg/ArmVirtQemu: switch to generic PciHostBridgeDxe
>   ArmVirtPkg/FdtPciHostBridgeLib: add MMIO64 support
>   ArmVirtPkg: remove now unused PciHostBridgeDxe
> 
>  ArmVirtPkg/ArmVirtQemu.dsc                                     |    7 +-
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc                           |    3 +-
>  ArmVirtPkg/ArmVirtQemuKernel.dsc                               |    7 +-
>  ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c   |  417 ++++
>  ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf |   56 +
>  ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c                    | 1496 --------------
>  ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.h                    |  499 -----
>  ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf               |   64 -
>  ArmVirtPkg/PciHostBridgeDxe/PciRootBridgeIo.c                  | 2144 --------------------
>  9 files changed, 487 insertions(+), 4206 deletions(-)
>  create mode 100644 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
>  create mode 100644 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
>  delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c
>  delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.h
>  delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf
>  delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciRootBridgeIo.c
> 

Awesome! I'm unsure when I'll have time to review this series during the
Forum, but I should (and will) say that I'm very grateful to you for
picking this up!

Cheers
Laszlo