From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C6521A1DF4 for ; Mon, 22 Aug 2016 04:58:51 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA2AD5455E; Mon, 22 Aug 2016 11:58:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-129.phx2.redhat.com [10.3.116.129]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7MBwXrP002780; Mon, 22 Aug 2016 07:58:39 -0400 To: Ard Biesheuvel , edk2-devel@ml01.01.org References: <1471847752-26574-1-git-send-email-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Mon, 22 Aug 2016 07:58:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471847752-26574-1-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 22 Aug 2016 11:58:50 +0000 (UTC) Subject: Re: [PATCH 0/5] ArmVirtQemu: move to generic PciHostBridgeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2016 11:58:51 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/22/16 02:35, Ard Biesheuvel wrote: > Now that Laszlo's virtio-gpu-pci have removed the last remaining obstacle, > we can get rid of the special PciHostBridgeDxe implementation in ArmVirtPkg, > and move to the generic one. This will allow us to perform DMA above 4GB > without bounce buffering, and use 64-bit MMIO BARs. > > Patch #1 removes the linux,pci-probe-only override which does more harm than > good now that we switched to virtio-gp-pci, which does not expose a raw > framebuffer. > > Patch #2 implements PciHostBridgeLib for platforms exposing a PCI host bridge > using a pci-host-ecam-generic DT node. > > Patch #3 switches to the generic PciHostBridgeDxe, with no change in > functionality other than support for DMA above 4 GB without bounce buffering. > > Patch #4 adds support for 64-bit MMIO BARs > > Patch #5 removes the now obsolete PciHostBridgeDxe from ArmVirPkg. > > Ard Biesheuvel (5): > ArmVirtPkg/PciHostBridgeDxe: don't set linux,pci-probe-only DT > property > ArmVirtPkg: implement FdtPciHostBridgeLib > ArmVirtPkg/ArmVirtQemu: switch to generic PciHostBridgeDxe > ArmVirtPkg/FdtPciHostBridgeLib: add MMIO64 support > ArmVirtPkg: remove now unused PciHostBridgeDxe > > ArmVirtPkg/ArmVirtQemu.dsc | 7 +- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +- > ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 417 ++++ > ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 56 + > ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c | 1496 -------------- > ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.h | 499 ----- > ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf | 64 - > ArmVirtPkg/PciHostBridgeDxe/PciRootBridgeIo.c | 2144 -------------------- > 9 files changed, 487 insertions(+), 4206 deletions(-) > create mode 100644 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c > create mode 100644 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.h > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciRootBridgeIo.c > Awesome! I'm unsure when I'll have time to review this series during the Forum, but I should (and will) say that I'm very grateful to you for picking this up! Cheers Laszlo