From: Laszlo Ersek <lersek@redhat.com>
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
Subject: Re: [Patch v2 0/5] Remove X86 ASM and S files
Date: Fri, 18 May 2018 13:43:23 +0200 [thread overview]
Message-ID: <a19abeed-b86d-6bb5-6a71-fbc9108416f3@redhat.com> (raw)
In-Reply-To: <1526635933-13976-1-git-send-email-liming.gao@intel.com>
Hi Limint,
On 05/18/18 11:32, Liming Gao wrote:
> For IA32 and X64, NASM has replaced ASM and S files.
> 1. Remove ASM from all modules.
> 2. Remove S files from the drivers only.
> 3. https://bugzilla.tianocore.org/show_bug.cgi?id=881
> After NASM is updated, S files can be removed from Library.
>
> V2:
> Update commit message.
>
> The patch set are in https://github.com/lgao4/edk2/tree/AsmClean
the commit message of v2 5/5 looks good to me -- if those commit message
changes are the only ones on the patch, relative to v1 5/5 [*], then
please add my
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
to v2 5/5.
[*]
http://mid.mail-archive.com/be509a29-1f64-79b6-9c75-64f88d29322c@redhat.com
Thanks!
Laszlo
next prev parent reply other threads:[~2018-05-18 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 9:32 [Patch v2 0/5] Remove X86 ASM and S files Liming Gao
2018-05-18 11:43 ` Laszlo Ersek [this message]
2018-05-23 2:51 ` Ni, Ruiyu
2018-05-23 3:28 ` Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19abeed-b86d-6bb5-6a71-fbc9108416f3@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox