From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 12ADF2096185E
 for <edk2-devel@lists.01.org>; Fri, 18 May 2018 04:43:25 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id E593B40200A6;
 Fri, 18 May 2018 11:43:24 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-74.rdu2.redhat.com
 [10.10.120.74])
 by smtp.corp.redhat.com (Postfix) with ESMTP id F3AB96B5BB;
 Fri, 18 May 2018 11:43:23 +0000 (UTC)
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
References: <1526635933-13976-1-git-send-email-liming.gao@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <a19abeed-b86d-6bb5-6a71-fbc9108416f3@redhat.com>
Date: Fri, 18 May 2018 13:43:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1526635933-13976-1-git-send-email-liming.gao@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.6]); Fri, 18 May 2018 11:43:24 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]);
 Fri, 18 May 2018 11:43:24 +0000 (UTC) for IP:'10.11.54.5'
 DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [Patch v2 0/5] Remove X86 ASM and S files
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 18 May 2018 11:43:26 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Limint,

On 05/18/18 11:32, Liming Gao wrote:
> For IA32 and X64, NASM has replaced ASM and S files.
> 1. Remove ASM from all modules.
> 2. Remove S files from the drivers only.
> 3. https://bugzilla.tianocore.org/show_bug.cgi?id=881
> After NASM is updated, S files can be removed from Library.
> 
> V2:
> Update commit message.
> 
> The patch set are in https://github.com/lgao4/edk2/tree/AsmClean

the commit message of v2 5/5 looks good to me -- if those commit message
changes are the only ones on the patch, relative to v1 5/5 [*], then
please add my

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

to v2 5/5.

[*]
http://mid.mail-archive.com/be509a29-1f64-79b6-9c75-64f88d29322c@redhat.com

Thanks!
Laszlo