From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org, dun.tan@intel.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files
Date: Tue, 31 Oct 2023 13:30:25 +0100 [thread overview]
Message-ID: <a1a365b0-05d6-cb38-4282-9e630255f025@redhat.com> (raw)
In-Reply-To: <CAMj1kXHLxP+BU8i9+Exi2hHiUKkZ9HgK2YLDFNwF5SB5GVScbw@mail.gmail.com>
On 10/30/23 15:36, Ard Biesheuvel wrote:
> On Fri, 27 Oct 2023 at 07:43, duntan <dun.tan@intel.com> wrote:
>>
>> Use BaseIoLibIntrinsic.inf in dsc files. The
>> BaseIoLibIntrinsic supports Tdx and sev now.
>> The BaseIoLibIntrinsicSev will be removed in
>> the following patches.
>>
>> Signed-off-by: Dun Tan <dun.tan@intel.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
While I agree that this patch *in itself* is (quite obviously) formally
correct, semantically it is wrong for OVMF; which is why I have NACKed
the whole series; see <https://edk2.groups.io/g/devel/message/110242>.
(Just highlighting it here too, lest it get lost in the review thread.)
Thanks,
Laszlo
>> ---
>> OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +-
>> OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
>> OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +-
>> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +-
>> OvmfPkg/Microvm/MicrovmX64.dsc | 2 +-
>> OvmfPkg/OvmfPkgIa32.dsc | 2 +-
>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-
>> OvmfPkg/OvmfPkgX64.dsc | 2 +-
>> OvmfPkg/OvmfXen.dsc | 2 +-
>> 9 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
>> index 302c90e7c2..06086e0cc5 100644
>> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
>> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
>> @@ -142,7 +142,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
>> index 6693342c5f..1376dd7468 100644
>> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
>> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
>> @@ -149,7 +149,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc
>> index 35942e02df..1d2a13dd92 100644
>> --- a/OvmfPkg/CloudHv/CloudHvX64.dsc
>> +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc
>> @@ -159,7 +159,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
>> index 182ec3705d..6623196c8b 100644
>> --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc
>> +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
>> @@ -146,7 +146,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|OvmfPkg/Library/CcProbeLib/DxeCcProbeLib.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
>> index 0f26f2a9a9..c76a135f9e 100644
>> --- a/OvmfPkg/Microvm/MicrovmX64.dsc
>> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc
>> @@ -157,7 +157,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
>> index fcd3a3fda5..a850465e77 100644
>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>> @@ -162,7 +162,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
>> index d0ae0b996d..9c6615b487 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>> @@ -167,7 +167,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
>> index a6811eee55..9e054aa489 100644
>> --- a/OvmfPkg/OvmfPkgX64.dsc
>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>> @@ -179,7 +179,7 @@
>> PciCapLib|OvmfPkg/Library/BasePciCapLib/BasePciCapLib.inf
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
>> index ccd3a873c7..ab4bdb2628 100644
>> --- a/OvmfPkg/OvmfXen.dsc
>> +++ b/OvmfPkg/OvmfXen.dsc
>> @@ -150,7 +150,7 @@
>> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
>> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
>> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf
>> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf
>> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf
>> --
>> 2.31.1.windows.1
>>
>>
>>
>>
>>
>>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110407): https://edk2.groups.io/g/devel/message/110407
Mute This Topic: https://groups.io/mt/102215668/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-31 12:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 5:42 [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev duntan
2023-10-27 5:42 ` [edk2-devel] [PATCH 1/7] MdePkg: Create TdxLibNull.inf instance duntan
2023-10-27 5:54 ` Ni, Ray
2023-10-27 5:56 ` Ni, Ray
2023-10-27 6:32 ` duntan
2023-10-27 5:42 ` [edk2-devel] [PATCH 2/7] MdePkg: Add CcProbeLibNull and TdxLibNull implement duntan
2023-10-27 5:42 ` [edk2-devel] [PATCH 3/7] MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c duntan
2023-10-27 5:42 ` [edk2-devel] [PATCH 4/7] MdePkg:support Tdx and sev in BaseIoLibIntrinsic duntan
2023-10-27 5:42 ` [edk2-devel] [PATCH 5/7] OvmfPkg: Add CcProbeLib in PlatformInitLib.inf duntan
2023-10-30 14:37 ` Ard Biesheuvel
2023-10-27 5:42 ` [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files duntan
2023-10-30 14:36 ` Ard Biesheuvel
2023-10-31 12:30 ` Laszlo Ersek [this message]
2023-10-31 13:19 ` Ard Biesheuvel
2023-10-27 5:43 ` [edk2-devel] [PATCH 7/7] MdePkg:remove BaseIoLibIntrinsicSev related code duntan
2023-10-27 5:49 ` [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Yao, Jiewen
2023-10-27 6:31 ` duntan
2023-10-27 7:06 ` Yao, Jiewen
2023-10-27 7:34 ` duntan
2023-10-27 8:05 ` duntan
2023-10-27 21:31 ` Lendacky, Thomas via groups.io
2023-10-28 11:40 ` Laszlo Ersek
2023-10-31 9:56 ` duntan
2023-10-31 17:06 ` Laszlo Ersek
2023-10-31 22:36 ` Laszlo Ersek
2023-11-02 8:49 ` duntan
2023-11-02 10:42 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a365b0-05d6-cb38-4282-9e630255f025@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox