From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 70484AC130D for ; Tue, 31 Oct 2023 12:30:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MBa3xgamxDUklxB6v2zjNIgcLoeUbEqqYpP9JAEbTNg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698755433; v=1; b=IrkmlnL+DrhfrVqJZ1pZte9fuYHxPgEB1DWb8IsTfvuGr66pjBBVKijYB48op8yXNP4JIDi/ J/wGEH7G6S4lMUTR0TT5xFFArpTsPZU6nkMJ4MTKWeZC2WL7O/8sKvewD125FomQmjhMfuFQ6zj bZiE4yyWDul8IeHoTD/47rN4= X-Received: by 127.0.0.2 with SMTP id qveTYY7687511xTuPFIEP0dP; Tue, 31 Oct 2023 05:30:33 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.184641.1698755432523170500 for ; Tue, 31 Oct 2023 05:30:32 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-2Y6LG8FONFGWFT97nVnVCA-1; Tue, 31 Oct 2023 08:30:28 -0400 X-MC-Unique: 2Y6LG8FONFGWFT97nVnVCA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B667101A53B; Tue, 31 Oct 2023 12:30:28 +0000 (UTC) X-Received: from [10.39.195.34] (unknown [10.39.195.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66EFB1121306; Tue, 31 Oct 2023 12:30:26 +0000 (UTC) Message-ID: Date: Tue, 31 Oct 2023 13:30:25 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files To: devel@edk2.groups.io, ardb@kernel.org, dun.tan@intel.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Ray Ni References: <20231027054300.1382-1-dun.tan@intel.com> <20231027054300.1382-7-dun.tan@intel.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qMseyatkAEFtzRVk411mO6Kex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IrkmlnL+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/30/23 15:36, Ard Biesheuvel wrote: > On Fri, 27 Oct 2023 at 07:43, duntan wrote: >> >> Use BaseIoLibIntrinsic.inf in dsc files. The >> BaseIoLibIntrinsic supports Tdx and sev now. >> The BaseIoLibIntrinsicSev will be removed in >> the following patches. >> >> Signed-off-by: Dun Tan >> Cc: Ard Biesheuvel >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Gerd Hoffmann >> Cc: Ray Ni >=20 > Reviewed-by: Ard Biesheuvel While I agree that this patch *in itself* is (quite obviously) formally correct, semantically it is wrong for OVMF; which is why I have NACKed the whole series; see . (Just highlighting it here too, lest it get lost in the review thread.) Thanks, Laszlo >> --- >> OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- >> OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- >> OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- >> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- >> OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- >> OvmfPkg/OvmfPkgIa32.dsc | 2 +- >> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- >> OvmfPkg/OvmfPkgX64.dsc | 2 +- >> OvmfPkg/OvmfXen.dsc | 2 +- >> 9 files changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc >> index 302c90e7c2..06086e0cc5 100644 >> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc >> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc >> @@ -142,7 +142,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc >> index 6693342c5f..1376dd7468 100644 >> --- a/OvmfPkg/Bhyve/BhyveX64.dsc >> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc >> @@ -149,7 +149,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64= .dsc >> index 35942e02df..1d2a13dd92 100644 >> --- a/OvmfPkg/CloudHv/CloudHvX64.dsc >> +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc >> @@ -159,7 +159,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTd= xX64.dsc >> index 182ec3705d..6623196c8b 100644 >> --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc >> +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc >> @@ -146,7 +146,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|OvmfPkg/Library/CcProbeLib/DxeCcProbeLib.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64= .dsc >> index 0f26f2a9a9..c76a135f9e 100644 >> --- a/OvmfPkg/Microvm/MicrovmX64.dsc >> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc >> @@ -157,7 +157,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> index fcd3a3fda5..a850465e77 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -162,7 +162,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index d0ae0b996d..9c6615b487 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -167,7 +167,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index a6811eee55..9e054aa489 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -179,7 +179,7 @@ >> PciCapLib|OvmfPkg/Library/BasePciCapLib/BasePciCapLib.inf >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc >> index ccd3a873c7..ab4bdb2628 100644 >> --- a/OvmfPkg/OvmfXen.dsc >> +++ b/OvmfPkg/OvmfXen.dsc >> @@ -150,7 +150,7 @@ >> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCa= pPciSegmentLib.inf >> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.= inf >> CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf >> - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >> + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf >> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oe= mHookStatusCodeLibNull.inf >> SerialPortLib|PcAtChipsetPkg/Library/SerialIoLib/SerialIoLib.inf >> MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >> -- >> 2.31.1.windows.1 >> >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110407): https://edk2.groups.io/g/devel/message/110407 Mute This Topic: https://groups.io/mt/102215668/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-