From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 14 May 2019 05:43:25 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3B23300319C; Tue, 14 May 2019 12:43:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-233.rdu2.redhat.com [10.10.120.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id 041546135A; Tue, 14 May 2019 12:43:23 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/4] Add DSC/FDF include segment files for network stack To: devel@edk2.groups.io, shenglei.zhang@intel.com References: <20190514073938.21528-1-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 14 May 2019 14:43:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190514073938.21528-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 14 May 2019 12:43:24 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/14/19 09:39, Zhang, Shenglei wrote: > There is a patch to remove the redudant IP4 only iSCSI/PXE/TCP drivers > from MdeModulePkg, which has been reviewed before edk2-stable201811 tag. > And we also have plan to move all network related libraries/modules to > NetworkPkg. In order to make these change more smoothly, 2 configuration > fragment files are provided for platform to enable the network stack > support, without directly reference the INF module path. > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 > > Fu Siyuan (4): > OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > Nt32Pkg: Update DSC/FDF to use NetworkPkg's include fragment file. > ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > EmulatorPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > > ArmVirtPkg/ArmVirt.dsc.inc | 10 +--- > ArmVirtPkg/ArmVirtQemu.dsc | 43 +++++----------- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 25 +--------- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 43 +++++----------- > EmulatorPkg/EmulatorPkg.dsc | 32 ++++++------ > EmulatorPkg/EmulatorPkg.fdf | 10 +--- > Nt32Pkg/Nt32Pkg.dsc | 75 +++------------------------- > Nt32Pkg/Nt32Pkg.fdf | 27 +--------- > OvmfPkg/OvmfPkgIa32.dsc | 70 ++++++++------------------ > OvmfPkg/OvmfPkgIa32.fdf | 29 +---------- > OvmfPkg/OvmfPkgIa32X64.dsc | 71 ++++++++------------------ > OvmfPkg/OvmfPkgIa32X64.fdf | 29 +---------- > OvmfPkg/OvmfPkgX64.dsc | 69 ++++++++----------------- > OvmfPkg/OvmfPkgX64.fdf | 29 +---------- > 14 files changed, 121 insertions(+), 441 deletions(-) > Two general comments: (1) We have 4 (not 2) include fragments for the DSC (Defines, Libs, Pcds, Components). This is not really relevant for any of the patches, but it could help with clarifying the blurb, if a v2 is needed. (2) The blurb states that the patches were originally authored by Fu Siyuan. However, the patches themselves don't start with "From: Fu Siyuan ...". This makes me think that the blurb is out of sync with the patches themselves, to some extent. Thanks Laszlo