From: "Huangming (Mark)" <huangming23@huawei.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
Ming Huang <heyi.guo@linaro.org>
Cc: <linaro-uefi@lists.linaro.org>, <edk2-devel@lists.01.org>,
<graeme.gregory@linaro.org>, <ard.biesheuvel@linaro.org>,
<guoheyi@huawei.com>, <wanghuiqiang@huawei.com>,
<zhangjinsong2@huawei.com>, <mengfanrong@huawei.com>,
<huangdaode@hisilicon.com>, <waip23@126.com>,
Jeremy Linton <jeremy.linton@arm.com>
Subject: Re: [PATCH edk2-platforms v2 00/15] Improve D0x platforms and bug fix
Date: Sat, 3 Feb 2018 15:50:53 +0800 [thread overview]
Message-ID: <a1a79d2b-2e6c-4591-1437-ea0f4c78afd1@huawei.com> (raw)
In-Reply-To: <20180129173307.e2pgjoxvmhvxmalx@bivouac.eciton.net>
On 2018/1/30 1:33, Leif Lindholm wrote:
> So, I'm mostly happy with this set, but:
>
> Sender (and hence Author for all patches that do not have a second
> From: statement after Subject: ) for all patches here is
> Ming Huang <heyi.guo@linaro.org>
>
> Can you please address this, either by actually sending from Ming Huang, or
> by adding a From:.
>
I had modify the auther to heyi Guo which is equal to the sender in V3, but
the emails do not have "From: " also, I am puzzle about that.
Maybe a Linaro email account for myself is the best solution.
Thanks,
Ming
> You can add my
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> to 3-4, 6-12 and 15.
>
> I have a few comments on 5/15, and then I need some input from others
> on the ACPI bits - especially from Jeremy, who should ideally have
> been cc:d on at least the PPTT patch given his comments on v1.
>
> /
> Leif
>
> On Fri, Jan 26, 2018 at 04:00:35PM +0800, Ming Huang wrote:
>> The major features of this patchset include
>> adding PPTT support,
>> switching to Generic BDS driver,
>> adding capsule upgrade support,
>> open-source version for SnpPlatform and SasPlatform
>> changing DmaLib to CoherentDmaLib(this one is omissive in v1).
>>
>> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
>> branch: rp-1802-platforms-v2
>>
>>
>> Jason Zhang (3):
>> Hisilicon D03/D05: Add capsule upgrade support
>> Hisilicon D03/D05: Open SasPlatform source code
>> Hisilicon D03/D05: Open SnpPlatform source code
>>
>> Ming Huang (11):
>> Hisilicon/D05: Move Madt definition to head file
>> Hisilicon/D05: Add PPTT support
>> Hisilicon/D0x/BDS: Switch to Generic BDS driver
>> Hisilicon/D0x: Break BMC SetBoot option out into separate library
>> Hilisicon: Change DmaLib to CoherentDmaLib
>> Hisilicon/Smbios: Indicate use of ProcessorFamily2 in type 4 table
>> Hisilicon/D05: Replace SP805Watchdog by WatchdogTimer driver.
>> Hisilicon/D03: Replace SP805Watchdog by WatchdogTimer driver.
>> Hisilicon/D05/ACPI: Add ITS PXM
>> Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM
>> Hisilicon D03/D05: Update firmware version to 18.02
>>
>> Yan Zhang (1):
>> Hisilicon/PCIe: Disable PCIe ASPM
>>
>> Platform/Hisilicon/D03/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 45 ++
>> Platform/Hisilicon/D03/D03.dsc | 42 +-
>> Platform/Hisilicon/D03/D03.fdf | 79 ++-
>> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 81 +++
>> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 50 ++
>> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c | 70 +++
>> Platform/Hisilicon/D05/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 45 ++
>> Platform/Hisilicon/D05/D05.dsc | 47 +-
>> Platform/Hisilicon/D05/D05.fdf | 80 ++-
>> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 81 +++
>> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 50 ++
>> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c | 70 +++
>> Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.c | 106 ++++
>> Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.inf | 45 ++
>> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 4 +-
>> Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.c | 115 ++++
>> Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf | 46 ++
>> Silicon/Hisilicon/Drivers/VirtualEhciPciIo/VirtualEhciPciIo.c | 2 +-
>> Silicon/Hisilicon/Hi1610/Drivers/IoInitDxe/IoInitDxe.c | 3 +-
>> Silicon/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c | 103 ++++
>> Silicon/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.h | 2 +
>> Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 +
>> Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl | 9 +
>> Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl | 34 +-
>> Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 19 +-
>> Silicon/Hisilicon/Hi1616/D05AcpiTables/Hi1616Platform.h | 30 +-
>> Silicon/Hisilicon/Hi1616/D05AcpiTables/MadtHi1616.aslc | 23 +-
>> Silicon/Hisilicon/Hi1616/Pptt/Pptt.c | 540 ++++++++++++++++
>> Silicon/Hisilicon/Hi1616/Pptt/Pptt.h | 88 +++
>> Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf | 48 ++
>> Silicon/Hisilicon/HisiPkg.dec | 6 +
>> Silicon/Hisilicon/Hisilicon.dsc.inc | 12 +-
>> Silicon/Hisilicon/Hisilicon.fdf.inc | 9 +
>> Silicon/Hisilicon/Include/Library/AcpiNextLib.h | 10 +-
>> Silicon/Hisilicon/Include/Library/BmcConfigBootLib.h | 31 +
>> Silicon/Hisilicon/Include/Library/OemDevicePath.h | 52 ++
>> Silicon/Hisilicon/Include/Protocol/HisiPlatformSasProtocol.h | 30 +
>> Silicon/Hisilicon/Include/Protocol/SnpPlatformProtocol.h | 32 +
>> Silicon/Hisilicon/Include/Regs/HisiPcieV1RegOffset.h | 2 +
>> Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.c | 466 ++++++++++++++
>> Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf | 51 ++
>> Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c | 643 ++++++++++++++++++++
>> Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.h | 31 +
>> Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 74 +++
>> Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.c | 123 ++++
>> Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.inf | 51 ++
>> 46 files changed, 3536 insertions(+), 54 deletions(-)
>> create mode 100644 Platform/Hisilicon/D03/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>> create mode 100644 Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
>> create mode 100644 Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
>> create mode 100644 Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
>> create mode 100644 Platform/Hisilicon/D05/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>> create mode 100644 Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
>> create mode 100644 Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
>> create mode 100644 Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
>> create mode 100644 Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.c
>> create mode 100644 Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.inf
>> create mode 100644 Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.c
>> create mode 100644 Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf
>> create mode 100644 Silicon/Hisilicon/Hi1616/Pptt/Pptt.c
>> create mode 100644 Silicon/Hisilicon/Hi1616/Pptt/Pptt.h
>> create mode 100644 Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf
>> create mode 100644 Silicon/Hisilicon/Include/Library/BmcConfigBootLib.h
>> create mode 100644 Silicon/Hisilicon/Include/Library/OemDevicePath.h
>> create mode 100644 Silicon/Hisilicon/Include/Protocol/HisiPlatformSasProtocol.h
>> create mode 100644 Silicon/Hisilicon/Include/Protocol/SnpPlatformProtocol.h
>> create mode 100644 Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.c
>> create mode 100644 Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
>> create mode 100644 Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c
>> create mode 100644 Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.h
>> create mode 100644 Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>> create mode 100644 Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.c
>> create mode 100644 Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.inf
>>
>> --
>> 1.9.1
>>
>
> .
>
--
Best Regards,
Ming
prev parent reply other threads:[~2018-02-03 7:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 8:00 [PATCH edk2-platforms v2 00/15] Improve D0x platforms and bug fix Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 01/15] Hisilicon/D05: Move Madt definition to head file Ming Huang
2018-01-30 14:27 ` graeme.gregory
2018-01-26 8:00 ` [PATCH edk2-platforms v2 02/15] Hisilicon/D05: Add PPTT support Ming Huang
2018-01-30 14:28 ` graeme.gregory
2018-02-01 1:11 ` Jeremy Linton
2018-02-02 3:42 ` Huangming (Mark)
2018-02-02 16:17 ` Jeremy Linton
2018-01-26 8:00 ` [PATCH edk2-platforms v2 03/15] Hisilicon/D0x/BDS: Switch to Generic BDS driver Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 04/15] Hisilicon/D0x: Break BMC SetBoot option out into separate library Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 05/15] Hisilicon D03/D05: Add capsule upgrade support Ming Huang
2018-01-29 19:58 ` Leif Lindholm
2018-01-30 12:48 ` Huangming (Mark)
2018-01-30 13:21 ` Leif Lindholm
2018-01-31 1:14 ` Huangming (Mark)
2018-01-30 12:47 ` Ard Biesheuvel
2018-01-26 8:00 ` [PATCH edk2-platforms v2 06/15] Hisilicon D03/D05: Open SasPlatform source code Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 07/15] Hisilicon D03/D05: Open SnpPlatform " Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 08/15] Hilisicon: Change DmaLib to CoherentDmaLib Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 09/15] Hisilicon/Smbios: Indicate use of ProcessorFamily2 in type 4 table Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 10/15] Hisilicon/PCIe: Disable PCIe ASPM Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 11/15] Hisilicon/D05: Replace SP805Watchdog by WatchdogTimer driver Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 12/15] Hisilicon/D03: " Ming Huang
2018-01-26 8:00 ` [PATCH edk2-platforms v2 13/15] Hisilicon/D05/ACPI: Add ITS PXM Ming Huang
2018-01-30 14:30 ` graeme.gregory
2018-01-26 8:00 ` [PATCH edk2-platforms v2 14/15] Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM Ming Huang
2018-01-30 14:31 ` graeme.gregory
2018-01-26 8:00 ` [PATCH edk2-platforms v2 15/15] Hisilicon D03/D05: Update firmware version to 18.02 Ming Huang
2018-01-29 17:33 ` [PATCH edk2-platforms v2 00/15] Improve D0x platforms and bug fix Leif Lindholm
2018-02-03 7:50 ` Huangming (Mark) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a79d2b-2e6c-4591-1437-ea0f4c78afd1@huawei.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox