From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.57081.1622550340264662235
 for <devel@edk2.groups.io>;
 Tue, 01 Jun 2021 05:25:40 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RnTecpyd;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1622550339;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xwg8VKGljlZcLXCwsjz73Sn/ZllhBaHVvwXw/HyNoz4=;
	b=RnTecpydOUNSDRmqmrg0J8oj/cydEgUTpB6ljcsqo9k+bwJZSOtp+dPmaxxeV6UKE6Z5cB
	AlJm2fVD88INuQUU3rROhjnS34jjawEBlWGQN8WMshO48/n8//6Vywq1VEkenlvsWXQDNM
	3v5SpAQVtzx4Lo83sO8gCDByj8V5kj0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-170-F2u9TCWZNVOa93m9C-wqVw-1; Tue, 01 Jun 2021 08:25:38 -0400
X-MC-Unique: F2u9TCWZNVOa93m9C-wqVw-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 534D3803622
	for <devel@edk2.groups.io>; Tue,  1 Jun 2021 12:25:37 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-181.ams2.redhat.com [10.36.114.181])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id B178E100164C;
	Tue,  1 Jun 2021 12:25:32 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] Add missing EFIAPI to VirtioMmioSetQueueAddress
To: devel@edk2.groups.io, kraxel@redhat.com
References: <20210528141647.2153504-1-kraxel@redhat.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <a1a87c06-e60f-d782-4980-f39cd4e44197@redhat.com>
Date: Tue, 1 Jun 2021 14:25:31 +0200
MIME-Version: 1.0
In-Reply-To: <20210528141647.2153504-1-kraxel@redhat.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Gerd,

On 05/28/21 16:16, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h          | 1 +
>  OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 1 +
>  2 files changed, 2 insertions(+)

Thanks for the patch!

(1) Please write a non-empty commit message body. For example, "This
error was found while compiling VirtioMmioDeviceLib for X64 with the
GCC5 toolchain, where EFIAPI makes a difference."

(I had to verify that the actual protocol member function type,
VIRTIO_SET_QUEUE_ADDRESS [OvmfPkg/Include/Protocol/VirtioDevice.h], did
spell out EFIAPI.)

(2) The patch contains some CRLF issues; please consider running
"BaseTools/Scripts/SetupGit.py" in your clone. Two things could be
missing in particular:

- the "8bit" (or even "base64") value for "sendemail.transferEncoding",
- the "cr-at-eol" value for "core.whitespace".

Thanks!
Laszlo

> 
> diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> index 785876c75f82..ab53b90d51c9 100644
> --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> @@ -107,6 +107,7 @@ VirtioMmioSetQueueSel (
>    );
> 
>  
> 
>  EFI_STATUS
> 
> +EFIAPI
> 
>  VirtioMmioSetQueueAddress (
> 
>    IN VIRTIO_DEVICE_PROTOCOL  *This,
> 
>    IN VRING                   *Ring,
> 
> diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> index 454f008827be..b0d75fb1dd24 100644
> --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> @@ -173,6 +173,7 @@ VirtioMmioSetQueueSel (
>  }
> 
>  
> 
>  EFI_STATUS
> 
> +EFIAPI
> 
>  VirtioMmioSetQueueAddress (
> 
>    IN VIRTIO_DEVICE_PROTOCOL  *This,
> 
>    IN VRING                   *Ring,
>