From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B7F1BD81113 for ; Mon, 11 Dec 2023 14:33:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Qse6dvTQcNOL91IJrivea1tuHfkgrUX78hrF62nBF5I=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702305224; v=1; b=H5Ytl1f4BZ8m/ZHep5W/ueRhN8gayApl9NoYG7HHGW3fDHL7ZmYJ65fQjcGRNprzQvtkQH8Y X7LDUjQg/22zLImib+CsgBshY6tr6TbJZ99fkCAztcnByxRN3/RfOiWQu2QF92SLC+hUwRtWbXu aR6qZnR0A8pqR6vrxbanxDk0= X-Received: by 127.0.0.2 with SMTP id wWiHYY7687511xewyCIB7OWA; Mon, 11 Dec 2023 06:33:44 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.9656.1702305223729908859 for ; Mon, 11 Dec 2023 06:33:43 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-nxaxwd_KNX6xCRFAyY-Jlg-1; Mon, 11 Dec 2023 09:31:46 -0500 X-MC-Unique: nxaxwd_KNX6xCRFAyY-Jlg-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 11A8510133B7; Mon, 11 Dec 2023 14:31:46 +0000 (UTC) X-Received: from [10.39.194.43] (unknown [10.39.194.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BDD92166B31; Mon, 11 Dec 2023 14:31:44 +0000 (UTC) Message-ID: Date: Mon, 11 Dec 2023 15:31:43 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3] ArmVirt: Allow memory attributes protocol to be disabled To: Gerd Hoffmann , Ard Biesheuvel Cc: devel@edk2.groups.io, Ard Biesheuvel , Oliver Steffen , Alexander Graf , Oliver Smith-Denny , Taylor Beebe , Peter Jones , Leif Lindholm References: <20231211104024.185070-1-ardb@google.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rTqUBRk6cjkjeeRsYOCC6g5Kx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=H5Ytl1f4; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 12/11/23 11:55, Gerd Hoffmann wrote: >> + // >> + // Work around shim's terminally broken use of the EFI memory attribu= tes >> + // protocol, by uninstalling it if requested on the QEMU command line= . >> + // >> + // E.g., >> + // -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=3D= y >> + // >> + // This is only needed on the first boot, when fbaa64.efi is being in= voked to >> + // set the boot order variables. Subsequent boots involving GRUB are = not >> + // affected. >> + // (1) I think this last paragraph of the comment no longer applies; is that right? We don't restrict the proto masking to first boot any longer (i.e., in v3). >> + Uninstall =3D FixedPcdGetBool (PcdUninstallMemAttrProtocol); >> + QemuFwCfgParseBool ("opt/org.tianocore/UninstallMemAttrProtocol", &Un= install); >> + if (Uninstall) { >> + UninstallEfiMemoryAttributesProtocol (); >> + } >=20 > Can we please have a log message here, for both uninstall and > keep-installed cases? Good idea! >=20 > Otherwise the patch looks good to me. With those two updates (assuming I'm right about (1)): Reviewed-by: Laszlo Ersek Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112301): https://edk2.groups.io/g/devel/message/112301 Mute This Topic: https://groups.io/mt/103106391/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-