Re: [edk2-devel] [PATCH v2 2/6] uefi-sct/SctPkg: TCG MOR SetVariable Test

["Stuart Yoder" <stuart.yoder@arm.com>]

See inline comments...

On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
> SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
> 
> -Implement MemoryOverwriteRequestControlSetVariable test cases
>   -Add Assertions 5, 6, 7, and 8 from SCT spec
>   -Add Test Case to MemoryOverwriteRequestFunctionTest
> 
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
> Signed-off-by: Abhi Singh <Abhi.Singh@arm.com>
> Change-Id: I21ed8d6613c7b9d20560b8fa4a45632008d756f9
> ---

[cut]

> +/**
> + *  MemoryOverwriteRequestControl EFI variable SetVariable() requests with a single invalid parameter
> + *  @param StandardLib    A pointer to EFI_STANDARD_TEST_LIBRARY_PROTOCOL
> + *                        instance.
> + *  @param RecoveryLib    A pointer to EFI_TEST_RECOVERY_LIBRARY_PROTOCOL
> + *                        instance.
> + *  @return EFI_SUCCESS   Successfully.
> + *  @return Other value   Something failed.
> + */
> +EFI_STATUS
> +TCGMemoryOverwriteRequestControlSetVariable (
> +  IN EFI_STANDARD_TEST_LIBRARY_PROTOCOL       *StandardLib,
> +  IN EFI_TEST_RECOVERY_LIBRARY_PROTOCOL       *RecoveryLib,
> +  IN RESET_DATA                               *ResetData
> +  )
> +{
> +  EFI_STATUS                           Status;
> +  EFI_TEST_ASSERTION                   Result;
> +  UINTN                                DataSize;
> +  UINT8                                MemoryOverwriteRequestControlData;
> +  UINT8                                MemoryOverwriteRequestControlDataCached;
> +  UINT32                               Attributes;
> +
> +  //
> +  // Write reset record to initiate checkpoint LOCK_SET_VARIABLE_TEST after these assertions are complete
> +  //
> +  ResetData->Step = 0;
> +  ResetData->CheckpointStep = LOCK_SET_VARIABLE_TEST;
> +
> +  Status = RecoveryLib->WriteResetRecord (
> +                  RecoveryLib,
> +                  sizeof (RESET_DATA),
> +                  (UINT8*)ResetData
> +                  );
> +  if (EFI_ERROR(Status)) {
> +    StandardLib->RecordAssertion (
> +                  StandardLib,
> +                  EFI_TEST_ASSERTION_FAILED,
> +                  gTestGenericFailureGuid,
> +                  L"TestRecoveryLib - WriteResetRecord",
> +                  L"%a:%d:Status - %r",
> +                  __FILE__,
> +                  (UINTN)__LINE__,
> +                  Status
> +                  );
> +    return Status;
> +  }
> +
> +  //
> +  //MOR SetVariable() with invalid DataSize == 0 returns EFI_INVALID_PARAMETER and value is unchanged
> +  //using GetVariable() before and after SetVariable() to compare values of the data
> +  //

Nit- space after comment char.

Thanks,
Stuart


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108963): https://edk2.groups.io/g/devel/message/108963
Mute This Topic: https://groups.io/mt/101504338/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-