From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7633621962301 for ; Thu, 16 Aug 2018 12:26:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7B44E7A7EE; Thu, 16 Aug 2018 19:26:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-198.rdu2.redhat.com [10.10.120.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id C33471040827; Thu, 16 Aug 2018 19:26:46 +0000 (UTC) To: Songpeng Li , edk2-devel@lists.01.org Cc: Siyuan Fu , Jiaxin Wu References: <20180816013757.9680-1-songpeng.li@intel.com> <20180816013757.9680-5-songpeng.li@intel.com> From: Laszlo Ersek Message-ID: Date: Thu, 16 Aug 2018 21:26:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180816013757.9680-5-songpeng.li@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 16 Aug 2018 19:26:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 16 Aug 2018 19:26:47 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 4/5] NetworkPkg: TlsDxe: Remove the redundant definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 19:26:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/16/18 03:37, Songpeng Li wrote: > The definition NetLib has been removed. (1) I suggest calling this "lib class dependency", not "definition". (I could have made the same for a GUID removed in a previous patch, but there "definition" seemed acceptable. "GUID dependency" would be an improvement there as well.) The subject line could also say, "remove superfluous dependencies". > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Laszlo Ersek > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Songpeng Li > --- > NetworkPkg/TlsDxe/TlsDxe.inf | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/NetworkPkg/TlsDxe/TlsDxe.inf b/NetworkPkg/TlsDxe/TlsDxe.inf > index 907feb735b..aaea0fc2ff 100644 > --- a/NetworkPkg/TlsDxe/TlsDxe.inf > +++ b/NetworkPkg/TlsDxe/TlsDxe.inf > @@ -5,7 +5,7 @@ > # This module produces EFI TLS (Transport Layer Security) Protocol and EFI TLS > # Service Binding Protocol, to provide TLS services. > # > -# Copyright (c) 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -52,7 +52,6 @@ > BaseLib > UefiLib > DebugLib > - NetLib > BaseCryptLib > TlsLib > > (2) This patch is incomplete; the file "NetworkPkg/TlsDxe/TlsImpl.h" contains: #include That header file is huge, so I won't try to audit, on a source code level, whether TlsDxe makes any NetLib API calls. (Note that even if it does, then the current patch need not necessarily cause a linking failure. Because, a NetLib dependency could be inherited through one of the library instances with which a given platform resolves the *other* lib class dependencies for TlsDxe.) So, please remove the #include too, and if TlsDxe still compiles, please resubmit the patch. (Otherwise, drop the patch, of course.) Thanks! Laszlo