From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3EF0FD804D6 for ; Tue, 6 Feb 2024 14:36:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WkrLkQWzmWoTClH+YJtJcdIXcYDBCu3+LJ/0yC01/48=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707230200; v=1; b=QGPbNzJpWuHXAyUErZEysvGhD+rYDjmZG23D3KWZPMthw3SCj4TwiJxG9GeppQMa8AEJZcSu LIa9c+Ckdsb8anUGvJSi8UAoxpWJUJNB/a+ZjY29kFFYcSNovfahZekR2fOXm0BK8uYXx8Tvv+C QqGrZXBU1MiUHOuSJeFhmhvo= X-Received: by 127.0.0.2 with SMTP id HWUMYY7687511xMF7JMrsuTG; Tue, 06 Feb 2024 06:36:40 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.22787.1707230200241057829 for ; Tue, 06 Feb 2024 06:36:40 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-mr-rzfIBOeW82DVmM-wZmg-1; Tue, 06 Feb 2024 09:36:35 -0500 X-MC-Unique: mr-rzfIBOeW82DVmM-wZmg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E8DF10201E8; Tue, 6 Feb 2024 14:36:35 +0000 (UTC) X-Received: from [10.39.195.129] (unknown [10.39.195.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 001CD1C060B1; Tue, 6 Feb 2024 14:36:33 +0000 (UTC) Message-ID: Date: Tue, 6 Feb 2024 15:36:32 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2 Patch 1/1] EmbeddedPkg: compiler error due to arithmetic operation on void pointer To: Ard Biesheuvel , devel@edk2.groups.io, n.jayaprakash@intel.com Cc: Rebecca Cran , Michael D Kinney , Leif Lindholm , Ard Biesheuvel , Abner Chang References: <20240206052320.1233-1-n.jayaprakash@intel.com> <20240206052320.1233-2-n.jayaprakash@intel.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EG38MHQ6ICNPnFMtquWrq5Lvx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=QGPbNzJp; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/6/24 13:57, Ard Biesheuvel wrote: > On Tue, 6 Feb 2024 at 05:23, Jayaprakash, N wro= te: >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4668 >> >> This commit fixes the issue reported in the BZ4668. >> The EmbeddedPkg fails to compile with a compiler error >> generated due to invalid/illegal arithmetic operation >> on void pointers. It has been fixed by using explicit >> type conversion of the void pointer to UINTN. >> >> Cc: Rebecca Cran >> Cc: Michael D Kinney >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Abner Chang >> Cc: Jayaprakash N >> Signed-off-by: Jayaprakash N >> --- >> .../Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocati= onLib.c b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.= c >> index fa81cc9d59..11566cf57f 100644 >> --- a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c >> +++ b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c >> @@ -308,7 +308,7 @@ ReallocatePool ( >> if (OldBuffer !=3D NULL) { >> HandOffHob =3D GetHobList (); >> ASSERT (((EFI_PHYSICAL_ADDRESS)(UINTN)OldBuffer >=3D HandOffHob->Ef= iMemoryBottom)); >> - ASSERT (((EFI_PHYSICAL_ADDRESS)(UINTN)(OldBuffer + OldSize) <=3D Ha= ndOffHob->EfiFreeMemoryBottom)); >> + ASSERT (((EFI_PHYSICAL_ADDRESS)(UINTN)((UINTN)OldBuffer + OldSize) = <=3D HandOffHob->EfiFreeMemoryBottom)); >=20 >=20 > Do we really need two UINTN casts here? >=20 No, that should not be necessary. In (msgid <01296486-5b14-4b73-b9dc-777a723548cf@redhat.com>), I recommended: -------------- We should replace (UINTN)(OldBuffer + OldSize) with ((UINTN)OldBuffer + OldSize). -------------- Note that the text to remove includes the original (UINTN) cast. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115167): https://edk2.groups.io/g/devel/message/115167 Mute This Topic: https://groups.io/mt/104193285/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-