From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.11206.1582876293352922996 for ; Thu, 27 Feb 2020 23:51:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Wr534XnE; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582876292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MyoAWE0GPOR78/L8HDHqK/Ush/uBzqW5fAQ1YNXSVmw=; b=Wr534XnEdQeb0V0fjdUCtMLDnl3p7DCdovMwRzr8MvdGLd4Fo1828pdQEvPygFmoggpjPi fdn1zJom0fjF4hlUdskcvXa60Hj5zxSeMUGz0Qy3kJi7/hl/gVVb9/YglzEeWPwh2NjCy5 hUxlJwbrYL4HtX6B5EkKqathGM5QD6g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-Z4jE7w7JPfKsIK8T6ThHzw-1; Fri, 28 Feb 2020 02:51:23 -0500 X-MC-Unique: Z4jE7w7JPfKsIK8T6ThHzw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82F588017DF; Fri, 28 Feb 2020 07:51:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-243.ams2.redhat.com [10.36.116.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id F35DA60BE0; Fri, 28 Feb 2020 07:51:20 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 00/13] OvmfPkg: Support booting from Fusion-MPT SCSI controllers To: devel@edk2.groups.io, nikita.leshchenko@oracle.com Cc: liran.alon@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200226164151.125182-1-nikita.leshchenko@oracle.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 28 Feb 2020 08:51:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200226164151.125182-1-nikita.leshchenko@oracle.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/26/20 17:41, Nikita Leshenko wrote: > This series adds driver support for: > - LSI53C1030 > - SAS1068 > - SAS1068E > > These controllers are widely supported by QEMU, VirtualBox and VMWare. This work > is part of the more general agenda of enhancing OVMF boot device support to have > feature parity with SeaBIOS. > > We have also developed support for PVSCSI which we will submit in a separate > patch series. > > I pushed a copy of these patches to https://github.com/nikital/edk2/tree/mptscsi > > v1->v2: > - Map() DMAed buffers > - Fixed various code convention issues > - Newer debug macros > - Updated INF version General comments: (1) In future cover letters, please include a cumulative diffstat. "git format-patch --cover-letter" should generate one. (2) Edk2 has migrated to using SPDX license identifiers, rather than open-coded license blocks: https://bugzilla.tianocore.org/show_bug.cgi?id=1373 Furthermore, the preferred license is "BSD-2-Clause-Patent": https://spdx.org/licenses/BSD-2-Clause-Patent.html Please see "Readme.md" in the project root, or at . (2a) Therefore please *at least* replace the open-coded BSD license blocks in the new files with SPDX tags. (2b) Furthermore, if you can consider making this contribution under "BSD-2-Clause-Patent", please change the license to that; it would be more in-line with the rest of edk2. (Otherwise, i.e. if you don't want to adopt "BSD-2-Clause-Patent", then please extend "OvmfPkg/License.txt" with the 2-clause BSD license, similarly to how "MIT" is treated there.) (2c) The "Contributed-under" tags should now be removed from the commit messages (see again TianoCore#1373). (3) Before posting the next version, please run "PatchCheck.py" on the series. For example: $ python3 BaseTools/Scripts/PatchCheck.py master..nikita-mptscsi-v2 Currently, it mainly reports "Contributed-under", but there's at least one other warning: "Line 3 of commit message is too long (78 >= 76)". Please try to fix warnings too. (4) Future versions should not be force-pushed to your repo, but pushed under a new topic branch whose name includes the version (i.e., the next version should have "v3" in the name). A topic branch, once published for review, should remain read-only. (5) Please do not include Reviewed-by and similar feedback tags that have not been given on the mailing list. For example, consider patch#4: "OvmfPkg/MptScsiDxe: Probe PCI devices and look for MptScsi" Version 1 is archived (for example) at: http://mid.mail-archive.com/20190131100724.20907-5-nikita.leshchenko@oracle.com If I remember correctly, that was the very first posting, and it already contained R-b's from Konrad, Aaron and Liran. For upstream reviews, such tags (i.e. those that originate off-list) are not useful -- they have to be given on the list, in response to the posting. (I'm pointing this out with v1 in order to show that v2 has not picked up the R-b's from the list either.) So please ask your colleagues to repost their R-b tags on the list (in response to the individual patches, or in response to the cover letter, if they approve the whole set). I'll continue with reviewing the individual patches now. Thanks! Laszlo