From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.3840.1573737566464000126 for ; Thu, 14 Nov 2019 05:19:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O7Jy8VUT; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573737565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DgBpFqTydTgvv4OwtH7RezFilcUYZuWXlYlGIhH+yFo=; b=O7Jy8VUTuu+W1yo8lA2K39diLA03LmdA3xNh+eZIuis2GmT/slg9pYdqyUUB68NYL//hwj 3acJwj9Pi1yfRe7grXOO/Qz8wWA+aXPV0LMic3IkFKuHjnat1j1k8w2n4b8d8kS5AjKNgs wEhCJQlimBaGK18M6A5jVjVYbJO9wTE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-qK68CMaZORKFyb3BY_R2uQ-1; Thu, 14 Nov 2019 08:19:21 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A62EDDBB8; Thu, 14 Nov 2019 13:19:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-80.ams2.redhat.com [10.36.117.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id D732260FC4; Thu, 14 Nov 2019 13:19:19 +0000 (UTC) Subject: Re: [edk2-devel] csm on edk2-platform To: tommaso.mazzoni@engicam.com, dwmw2@infradead.org References: Cc: devel@edk2.groups.io From: "Laszlo Ersek" Message-ID: Date: Thu, 14 Nov 2019 14:19:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: qK68CMaZORKFyb3BY_R2uQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi David, could you please look into this briefly? Tommaso: please provide David with a more complete description of the symptom that you see. Can you tell what line exactly in edk2 triggers the problem? Thanks Laszlo On 11/06/19 17:17, Tommaso Mazzoni wrote: > Dear all, >=20 > Dear David Woodhouse, >=20 > I'm trying to add Csm packages to my edk2-platform (based on > devel-IntelAtomProcessorE3900 branch). I customized the repository to > fit a custom module based on Apollo Lake CPU. >=20 > edk2 is the UDK2018 branch. >=20 > I generated Csm16.bin with David Woodhouse SeaBios > (git://git.infradead.org/users/dwmw2/seabios.git). >=20 > Then I updated LegacyBbs.c in LegacyBiosDxe.inf because edk2-UDK2018 > version supports only Floppy and IDE HDD. I used LegacyBbs.c from > edk2-master to scan also removable devices. >=20 > Now I can scan removable devices and Boot Manager populate the boot list > with Legacy options, even it calls all options "Harddisk". >=20 > So I can try to boot it but the boot procedure stacks when it try to > disconnect EFI devices (in PciShadowRoms function of LegacyPci.c). > Function starts to disconnect from VGA, at that point boot stacks. >=20 > My dsc file contains the following includes: >=20 > =C2=A0=C2=A0 MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 > =C2=A0=C2=A0 !ifdef $(CSM_ENABLE) > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 NULL|OvmfPkg/Csm/CsmSup= portLib/CsmSupportLib.inf > =C2=A0=C2=A0 > NULL|IntelFrameworkModulePkg/Library/LegacyBootManagerLib/LegacyBootManag= erLib.inf >=20 > =C2=A0=C2=A0 !endif > =C2=A0=C2=A0=C2=A0 =C2=A0 } > =C2=A0=C2=A0 MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA= pp.inf { > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 > =C2=A0=C2=A0 DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.in= f > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 } > =C2=A0=C2=A0=C2=A0 =C2=A0 MdeModulePkg/Application/UiApp/UiApp.inf { > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 > =C2=A0=C2=A0 NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUi= Lib.inf > =C2=A0=C2=A0 NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.= inf > =C2=A0=C2=A0 > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceMana= gerUiLib.inf >=20 > =C2=A0=C2=A0 !ifdef $(CSM_ENABLE) > =C2=A0=C2=A0 > NULL|IntelFrameworkModulePkg/Library/LegacyBootManagerLib/LegacyBootManag= erLib.inf >=20 > =C2=A0=C2=A0 > NULL|IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBootMaint= UiLib.inf >=20 > =C2=A0=C2=A0 !endif > =C2=A0=C2=A0=C2=A0 =C2=A0 } >=20 > and: >=20 > =C2=A0=C2=A0 !ifdef $(CSM_ENABLE) >=20 > =C2=A0=C2=A0 IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/KeyboardDx= e.inf >=20 > =C2=A0=C2=A0 IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf >=20 > =C2=A0=C2=A0 IntelFrameworkModulePkg/Csm/BiosThunk/BlockIoDxe/BlockIoDxe.= inf >=20 > =C2=A0=C2=A0 IntelFrameworkModulePkg/Csm/BiosThunk/Snp16Dxe/Snp16Dxe.inf >=20 > =C2=A0=C2=A0 IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf >=20 > =C2=A0=C2=A0 OvmfPkg/Csm/Csm16/Csm16.inf >=20 > =C2=A0=C2=A0 !endif >=20 > I try to replicate what Laszlo suggest in > https://ml01.01.org/hyperkitty/list/edk2-devel@lists.01.org/thread/AT7EWP= IOJ3GUPBAHIDZLR5V5ZK5S442K/ >=20 >=20 > Do you have any suggestions? Do you understand what is happening? >=20 > Thank you. >=20 > Best regards, >=20 >=20