From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 10 Jul 2019 03:12:50 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 462C6C05B03B; Wed, 10 Jul 2019 10:12:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-153.ams2.redhat.com [10.36.117.153]) by smtp.corp.redhat.com (Postfix) with ESMTP id 985A15FCCA; Wed, 10 Jul 2019 10:12:47 +0000 (UTC) Subject: Re: [PATCH v3 31/35] OvmfPkg/OvmfXen: Introduce XenTimerDxe To: Anthony PERARD , devel@edk2.groups.io Cc: xen-devel@lists.xenproject.org, Ard Biesheuvel , Jordan Justen , Julien Grall References: <20190704144233.27968-1-anthony.perard@citrix.com> <20190704144233.27968-32-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 10 Jul 2019 12:12:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190704144233.27968-32-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 10 Jul 2019 10:12:49 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/04/19 16:42, Anthony PERARD wrote: > "PcAtChipsetPkg/8254TimerDxe" is replaced with a Xen-specific > EFI_TIMER_ARCH_PROTOCOL implementation. Also remove > 8259InterruptControllerDxe as it is not used anymore. > > This Timer uses the local APIC timer as time source as it can work on > both a Xen PVH guest and an HVM one. > > Based on the "PcAtChipsetPkg/8254TimerDxe" implementation. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > --- > > Notes: > v3: > - rebased, SPDX, copyright (1) Please replace both occurrences of "PcAtChipsetPkg" in the commit message with "OvmfPkg". (You rebased the DSC/FDF files correctly, but missed the commit message.) With that: Acked-by: Laszlo Ersek