From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.16543.1638984168048338476 for ; Wed, 08 Dec 2021 09:22:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C3cDJo2q; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638984167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WSWkbc+Cy1KgdLnnCjrZc+eEtWsps2tCwLR3IXhOPWY=; b=C3cDJo2qMwKpBfLXZTBFhBA/QFcjkGeyu1sj5S0m3KylRHL1GFZ6LSvDh+PQkmTEmsTV2J CcGl01UGZ/vIGNm+9ZrrMbqkGAO5x7nloaBlkjaq/vyaoFmoWcoOKDCFUccsWHRFKYz8wC p9qqzST4OnQI41cjACxBa3ifLwsBkGY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-542-BzfBTMUgOjW1XW6uWBgjaw-1; Wed, 08 Dec 2021 12:22:37 -0500 X-MC-Unique: BzfBTMUgOjW1XW6uWBgjaw-1 Received: by mail-wm1-f70.google.com with SMTP id r129-20020a1c4487000000b00333629ed22dso3329241wma.6 for ; Wed, 08 Dec 2021 09:22:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WSWkbc+Cy1KgdLnnCjrZc+eEtWsps2tCwLR3IXhOPWY=; b=cbMS6Rm+v+0xyjc6BORJLdWwos3TjVhu+bbiBf269S3AUZ4ohNi66T4tAN6p3RKvuF AQi/GWZ9Bg99+gY9oUROBiSS0uDyScXIy5ZweSkR6hCPHc/H3HJoC89OL0Ec0C4OF58w iS4Tl7mtx22mur+mUbRNDwL5Fylkw2CaP4sktO+K5AeamL8NeCaRXpo3OIhGokPElJg/ o2v0ZifT82bvePuSKMn7c0uk0GEP2CeJILEjQoqRkR8K7VVSEKoFKC3mACJrZNOo3rac e3YcfyDn49cLdhEmXCcLhcLWc5yoTqJWCiUc4PGGCmr3wQUYs3+t2FxTvLMisaerhjCx bjIg== X-Gm-Message-State: AOAM532gd4LqrJd9GCBP4Pza4NK+3dRE6B8eedh0QlYKiKwRDGoHuzvp ho3Yoc/vl5xW2E6B/rt/P+rBlfYA9fuQ3WA1l77RGVg7H0zEuLcajGmvsCmPAzycoXgoZoo8oA9 fSyp9GIGl3MunBQ== X-Received: by 2002:a05:600c:22ce:: with SMTP id 14mr32254wmg.152.1638984154232; Wed, 08 Dec 2021 09:22:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxWe77iSbtc9DI0Sytp+ibGCFRXagOsAm773QNqEvUThBFPrdyZ6Gp75si7BLXh8tL1vWcJbg== X-Received: by 2002:a05:600c:22ce:: with SMTP id 14mr32202wmg.152.1638984154006; Wed, 08 Dec 2021 09:22:34 -0800 (PST) Return-Path: Received: from [192.168.1.36] (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id n7sm3362680wro.68.2021.12.08.09.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Dec 2021 09:22:33 -0800 (PST) Message-ID: Date: Wed, 8 Dec 2021 18:22:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe) To: Ard Biesheuvel Cc: edk2-devel-groups-io , Pawel Polawski , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky , Laszlo Ersek References: <20211118204621.86224-1-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/8/21 17:47, Ard Biesheuvel wrote: > On Wed, 8 Dec 2021 at 17:43, Philippe Mathieu-Daudé wrote: >> >> Ping? >> > > I'll pick this up once the stable tag is released. Oh, I read "The hard freeze has ended and normal development activities can continue." in https://edk2.groups.io/g/devel/message/84458 but didn't notice the tag was not yet pushed. Thanks for picking this patch Ard :) > >> On 11/18/21 21:46, Philippe Mathieu-Daudé wrote: >>> From: Philippe Mathieu-Daude >>> >>> PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, >>> and those are consumed by the following PrintLib instance: >>> >>> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf >>> >>> However, none of the OVMF DSC files contain such a PrintLib class >>> resolution, so none of the OVMF platforms need PrintDxe. >>> >>> Cc: Ard Biesheuvel >>> Cc: Jordan Justen >>> Cc: Brijesh Singh >>> Cc: Erdem Aktas >>> Cc: Gerd Hoffmann >>> Cc: James Bottomley >>> Cc: Jiewen Yao >>> Cc: Min Xu >>> Cc: Tom Lendacky >>> Suggested-by: Laszlo Ersek >>> Reviewed-by: Jiewen Yao >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3744 >>> Signed-off-by: Philippe Mathieu-Daude >>> --- >>> Since v3: >>> - Remove from MicrovmX64 >>> - Reference BZ#3744 (Jiewen Yao) >>> - Add Jiewen Yao R-b tag >>> >>> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - >>> OvmfPkg/Bhyve/BhyveX64.dsc | 1 - >>> OvmfPkg/Microvm/MicrovmX64.dsc | 1 - >>> OvmfPkg/OvmfPkgIa32.dsc | 1 - >>> OvmfPkg/OvmfPkgIa32X64.dsc | 1 - >>> OvmfPkg/OvmfPkgX64.dsc | 1 - >>> OvmfPkg/OvmfXen.dsc | 1 - >>> OvmfPkg/AmdSev/AmdSevX64.fdf | 1 - >>> OvmfPkg/Bhyve/BhyveX64.fdf | 1 - >>> OvmfPkg/Microvm/MicrovmX64.fdf | 1 - >>> OvmfPkg/OvmfPkgIa32.fdf | 1 - >>> OvmfPkg/OvmfPkgIa32X64.fdf | 1 - >>> OvmfPkg/OvmfPkgX64.fdf | 1 - >>> OvmfPkg/OvmfXen.fdf | 1 - >>> 14 files changed, 14 deletions(-) >>> >>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc >>> index 5ee54451169b..24f228936703 100644 >>> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc >>> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc >>> @@ -731,7 +731,6 @@ [Components] >>> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> } >>> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc >>> index d8fe607d1cf7..268c18fe3bfc 100644 >>> --- a/OvmfPkg/Bhyve/BhyveX64.dsc >>> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc >>> @@ -675,7 +675,6 @@ [Components] >>> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> } >>> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc >>> index 617f92539518..a8c975a6bd04 100644 >>> --- a/OvmfPkg/Microvm/MicrovmX64.dsc >>> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc >>> @@ -710,7 +710,6 @@ [Components] >>> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> } >>> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >>> index 6a5be97c059d..074c77826344 100644 >>> --- a/OvmfPkg/OvmfPkgIa32.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32.dsc >>> @@ -825,7 +825,6 @@ [Components] >>> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> } >>> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >>> index 71227d1b709a..cf17e63c6319 100644 >>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >>> @@ -839,7 +839,6 @@ [Components.X64] >>> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> } >>> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >>> index 52f7598cf1c7..787d1086ee7e 100644 >>> --- a/OvmfPkg/OvmfPkgX64.dsc >>> +++ b/OvmfPkg/OvmfPkgX64.dsc >>> @@ -837,7 +837,6 @@ [Components] >>> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> } >>> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc >>> index a31519e356b7..fcf1188a3c47 100644 >>> --- a/OvmfPkg/OvmfXen.dsc >>> +++ b/OvmfPkg/OvmfXen.dsc >>> @@ -614,7 +614,6 @@ [Components] >>> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> } >>> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf >>> index 56626098862c..5a84393b00a0 100644 >>> --- a/OvmfPkg/AmdSev/AmdSevX64.fdf >>> +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf >>> @@ -245,7 +245,6 @@ [FV.DXEFV] >>> INF MdeModulePkg/Application/UiApp/UiApp.inf >>> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf >>> index b3b4d44cef34..e8227f865f75 100644 >>> --- a/OvmfPkg/Bhyve/BhyveX64.fdf >>> +++ b/OvmfPkg/Bhyve/BhyveX64.fdf >>> @@ -233,7 +233,6 @@ [FV.DXEFV] >>> INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >>> INF MdeModulePkg/Application/UiApp/UiApp.inf >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf b/OvmfPkg/Microvm/MicrovmX64.fdf >>> index 6314014f3de7..b6f080768835 100644 >>> --- a/OvmfPkg/Microvm/MicrovmX64.fdf >>> +++ b/OvmfPkg/Microvm/MicrovmX64.fdf >>> @@ -244,7 +244,6 @@ [FV.DXEFV] >>> INF MdeModulePkg/Application/UiApp/UiApp.inf >>> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf >>> index 775ea2d71098..c30e5281872f 100644 >>> --- a/OvmfPkg/OvmfPkgIa32.fdf >>> +++ b/OvmfPkg/OvmfPkgIa32.fdf >>> @@ -255,7 +255,6 @@ [FV.DXEFV] >>> INF MdeModulePkg/Application/UiApp/UiApp.inf >>> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf >>> index 9d8695922f97..78a01b6663ad 100644 >>> --- a/OvmfPkg/OvmfPkgIa32X64.fdf >>> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf >>> @@ -259,7 +259,6 @@ [FV.DXEFV] >>> INF MdeModulePkg/Application/UiApp/UiApp.inf >>> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf >>> index b6cc3cabdd69..a2c7a4d7a48d 100644 >>> --- a/OvmfPkg/OvmfPkgX64.fdf >>> +++ b/OvmfPkg/OvmfPkgX64.fdf >>> @@ -275,7 +275,6 @@ [FV.DXEFV] >>> INF MdeModulePkg/Application/UiApp/UiApp.inf >>> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf >>> index 8b5823555937..a6acf3b835aa 100644 >>> --- a/OvmfPkg/OvmfXen.fdf >>> +++ b/OvmfPkg/OvmfXen.fdf >>> @@ -326,7 +326,6 @@ [FV.DXEFV] >>> INF MdeModulePkg/Application/UiApp/UiApp.inf >>> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >>> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >>> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >>> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >>> >> >