From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.229.1605313053541675281 for ; Fri, 13 Nov 2020 16:17:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZagS7jPP; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605313052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4a1Mbq7Ive103n2z2yA6EIdaTYaS47jo/2uCybN3bqc=; b=ZagS7jPPrjQ8ygd/K/5tTs+CzinsYutAKMoCgyi20CWqhWaU+BVSu14HaFR4fekrDxsKBG TCpu11hY0xd+Fk+9bMUpekq2dZvahojrwdrFTJx2dQ1pUprnlqWh/M6riRWba6IXJ7Ma1g Xqz1t3TYA0eHIVV7okoKTHDbwjPy1ck= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-WV9YtmXaPZ2ZICcB2hPH2w-1; Fri, 13 Nov 2020 19:17:28 -0500 X-MC-Unique: WV9YtmXaPZ2ZICcB2hPH2w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 446D7427C0; Sat, 14 Nov 2020 00:17:26 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-113.ams2.redhat.com [10.36.112.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id A296727CC9; Sat, 14 Nov 2020 00:17:21 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V4 12/13] NetworkPkg/Defines: Make iSCSI disable as default To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Jordan Justen , Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Michael D Kinney , Kelly Steele , Zailiang Sun , Yi Qian , Liming Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu References: <20201112055558.2348-1-zhichao.gao@intel.com> <20201112055558.2348-13-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: Date: Sat, 14 Nov 2020 01:17:20 +0100 MIME-Version: 1.0 In-Reply-To: <20201112055558.2348-13-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/12/20 06:55, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 > > iSCSI is using the deprecated function MD5. It is > better to make the default setting secure. If the platforms > want to use the iSCSI, they should enable it in the platforms' > dsc file and be aware they are using an function with weak > cryptography. > > Enable iSCSI in NetworkPkg.dsc for build. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Leif Lindholm > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Michael D Kinney > Cc: Kelly Steele > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Liming Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Zhichao Gao > --- > NetworkPkg/NetworkDefines.dsc.inc | 4 ++-- > NetworkPkg/NetworkPkg.dsc | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/NetworkPkg/NetworkDefines.dsc.inc b/NetworkPkg/NetworkDefines.dsc.inc > index a442d1b157..18921d81f6 100644 > --- a/NetworkPkg/NetworkDefines.dsc.inc > +++ b/NetworkPkg/NetworkDefines.dsc.inc > @@ -17,7 +17,7 @@ > # DEFINE NETWORK_TLS_ENABLE = TRUE > # DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE > # DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = FALSE > -# DEFINE NETWORK_ISCSI_ENABLE = TRUE > +# DEFINE NETWORK_ISCSI_ENABLE = FALSE > # DEFINE NETWORK_VLAN_ENABLE = TRUE > # > # Copyright (c) 2019, Intel Corporation. All rights reserved.
> @@ -101,7 +101,7 @@ > # Both OpensslLib.inf and OpensslLibCrypto.inf library instance can be used > # since libssl is not required for iSCSI. > # > - DEFINE NETWORK_ISCSI_ENABLE = TRUE > + DEFINE NETWORK_ISCSI_ENABLE = FALSE > !endif > > !if $(NETWORK_ENABLE) == TRUE > diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc > index 716d04fdad..e508995e3a 100644 > --- a/NetworkPkg/NetworkPkg.dsc > +++ b/NetworkPkg/NetworkPkg.dsc > @@ -2,7 +2,7 @@ > # UEFI 2.4 Network Module Package for All Architectures > # > # (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> -# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.
> # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -18,6 +18,8 @@ > BUILD_TARGETS = DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER = DEFAULT > > + DEFINE NETWORK_ISCSI_ENABLE = TRUE > + > [LibraryClasses] > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > Reviewed-by: Laszlo Ersek