From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.52390.1597697079920885653 for ; Mon, 17 Aug 2020 13:44:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UPQ4s2Yq; spf=none, err=SPF record not found (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597697078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q4O2uBeqwCgwfoCUjY4b5534MQQoG8SRi5npy0WErTo=; b=UPQ4s2YqA5eEIyCLtY1R9Z/W4QWmISWdpTWx6CjSpqTyzAka2CSkYoFac2Os89S0ULTaq5 23SImU1rAb6IyaWhrPzQjY/i5UII0qDtsJAB5hkLIsWgqbX34W2RLp5bqH2iVctPlUf5nm Rhn5pfsgasbSisKO2Av1Kb3wnisiVpc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-9-9o3LPUudOumzhkrdWEri3g-1; Mon, 17 Aug 2020 16:44:34 -0400 X-MC-Unique: 9o3LPUudOumzhkrdWEri3g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2C291DDEC; Mon, 17 Aug 2020 20:44:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-161.ams2.redhat.com [10.36.112.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11EFA60BF3; Mon, 17 Aug 2020 20:44:29 +0000 (UTC) Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Vladimir Olovyannikov , "Rabeda, Maciej" , "Gao, Zhichao" , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , "Wu, Jiaxin" , "Fu, Siyuan" , "Ni, Ray" , "Gao, Liming" , Nd References: <20200727164830.25829-1-vladimir.olovyannikov@broadcom.com> <20200727164830.25829-2-vladimir.olovyannikov@broadcom.com> <25b5ce9498095e68650b8817e4523714@mail.gmail.com> <2a710789-bfdd-dd80-386a-04fbd46d4835@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 17 Aug 2020 22:44:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/17/20 20:29, Vladimir Olovyannikov wrote: >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Monday, August 17, 2020 11:01 AM >> To: Rabeda, Maciej ; Vladimir Olovyannikov >> ; Gao, Zhichao >> ; devel@edk2.groups.io >> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin >> ; Fu, Siyuan ; Ni, Ray >> ; Gao, Liming ; Nd >> >> Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add >> HttpDynamicCommand >> >> On 08/17/20 19:15, Rabeda, Maciej wrote: >>> Hi Vladimir, >>> >>> I cannot apply the patch via 'git am'. >>> Is your git configured in a manner described here? >>> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt >>> -git-guide-for-edk2-contributors-and-maintainers > Hi Rabeda, > Yes, I followed the page. I did not run the SetupGit.py though. >>> >>> >>> Laszlo, >>> >>> Were you able to apply this patch from .eml file? >> >> Yes, but I had to use some tricks (implemented by my colleague Paolo in a >> python script) to undo the damage caused by the "quoted-printable" >> content-transfer-encoding on the posting. >> >> Our recommended Content-Transfer-Encoding (that is, >> "sendemail.transferEncoding") is "8bit", or even "base64". >> quoted-printable is practically impossible to get functional, with the >> hard >> CRLF line endings in edk2. >> >> "BaseTools/Scripts/SetupGit.py" does set "8bit". > Thank you for notice Laszlo, > So, should I run this script and re-send the patch as v6? I think that would be useful, yes -- and if you have made no changes since v5, you can also post it as "v5 RESEND". If you've implemented some changes meanwhile, then please post it as v6 indeed. Thanks Laszlo