From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE
Date: Fri, 2 Dec 2022 08:38:10 -0700 [thread overview]
Message-ID: <a25f1fc6-d8ec-e539-6593-a82200ee2d01@quicinc.com> (raw)
In-Reply-To: <DM6PR11MB40258C84510992B443BB71C8CA179@DM6PR11MB4025.namprd11.prod.outlook.com>
On 12/1/22 18:26, Wu, Hao A wrote:
> Sorry for a question.
>
> For the changes in EhcBulkTransfer() and XhcBulkTransfer(), is it feasible
> to distinguish timeout cases with other error cases and only adjust
> timeout related messages to VERBOSE level?
No problem!
Something like this?
if (EFI_ERROR (Status)) {
if (Status == EFI_TIMEOUT) {
DebugErrorLevel = DEBUG_VERBOSE;
} else {
DebugErrorLevel = DEBUG_ERROR;
}
DEBUG ((DebugErrorLevel, "XhcBulkTransfer: error - %r, transfer -
%x\n", Status, *TransferResult));
}
I'll send out a v2 patch.
--
Rebecca Cran
next prev parent reply other threads:[~2022-12-02 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 21:00 [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE Rebecca Cran
2022-12-02 1:26 ` Wu, Hao A
2022-12-02 15:38 ` Rebecca Cran [this message]
2022-12-05 1:49 ` [edk2-devel] " Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25f1fc6-d8ec-e539-6593-a82200ee2d01@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox