From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.78668.1669995499821472895 for ; Fri, 02 Dec 2022 07:38:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=JaVYFIRm; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B2ArZ52010633; Fri, 2 Dec 2022 15:38:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=gXNialBX5lBeiK2o+fL6Jp7S8DCR+Z0rXdiWUPBhOC4=; b=JaVYFIRmyLeWCmztM2+d6hNNoYqu8Czd/Q6QMb2Xd+6IGnLTvUo9EenpusYrtSWJYv4Z VsCva1nOaRpUpPYAUuWmRQMPGqAZKrtjxO0doXIFpnimfngRezf5ZHIMoJ2CxFsw2Snp VJLahsY4jY9Llc2xve8lHLWW0Gu5HPfhCjqSJW7HXsOBFJrI/sWuV75urBovrRVD/4ff pHRCL0yq4E+ipAXX7I/QTBKWpjVOKRH9eoKleUQrX4A88e4+WT5HPJX+J+seBByHZ1IA 3fWFL+5Q96MjFkER6Sg3uLEfLGmbxtbNmx8AlEYeh6Rvltqv2EjlpnynTITNpAF1Dwzv OQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m7c221pgn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Dec 2022 15:38:12 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2B2FcBJu030977 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Dec 2022 15:38:11 GMT Received: from [10.110.26.238] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 2 Dec 2022 07:38:11 -0800 Message-ID: Date: Fri, 2 Dec 2022 08:38:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE To: "Wu, Hao A" , "devel@edk2.groups.io" , "Wang, Jian J" , "Gao, Liming" , "Ni, Ray" References: <20221201210007.62020-1-rebecca@quicinc.com> From: "Rebecca Cran" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: F2blgvNqnT9WEaHiuTh9cxGVtVwpvBsW X-Proofpoint-GUID: F2blgvNqnT9WEaHiuTh9cxGVtVwpvBsW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-02_08,2022-12-01_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 mlxscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=661 spamscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212020122 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 12/1/22 18:26, Wu, Hao A wrote: > Sorry for a question. > > For the changes in EhcBulkTransfer() and XhcBulkTransfer(), is it feasible > to distinguish timeout cases with other error cases and only adjust > timeout related messages to VERBOSE level? No problem! Something like this? if (EFI_ERROR (Status)) { if (Status == EFI_TIMEOUT) { DebugErrorLevel = DEBUG_VERBOSE; } else { DebugErrorLevel = DEBUG_ERROR; } DEBUG ((DebugErrorLevel, "XhcBulkTransfer: error - %r, transfer - %x\n", Status, *TransferResult)); } I'll send out a v2 patch. -- Rebecca Cran