From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id AE9282119F05B
 for <edk2-devel@lists.01.org>; Thu, 13 Dec 2018 02:33:16 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 7524730DDBD1;
 Thu, 13 Dec 2018 10:33:16 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-134.rdu2.redhat.com
 [10.10.120.134])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 58C921823F;
 Thu, 13 Dec 2018 10:33:15 +0000 (UTC)
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <liming.gao@intel.com>
References: <20181213083439.28716-1-shenglei.zhang@intel.com>
 <20181213083439.28716-2-shenglei.zhang@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <a27116c7-59cf-a7f9-5852-85785857adb2@redhat.com>
Date: Thu, 13 Dec 2018 11:33:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181213083439.28716-2-shenglei.zhang@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.49]); Thu, 13 Dec 2018 10:33:16 +0000 (UTC)
Subject: Re: [PATCH 1/2] MdePkg/BaseLib: Add two public functions
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 10:33:17 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 12/13/18 09:34, Shenglei Zhang wrote:
> Add two public functions, CharToUpper and AsciiToUpper.
> InternalCharToUpper and InternalBaseLibAsciiToUpper have the same
> functions as CharToUpper and AsciiToUpper, but they are internal ones.
> So the internal ones are removed and replace them with public ones
> in other places.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1369
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdePkg/Include/Library/BaseLib.h          | 40 +++++++++++++++++++++
>  MdePkg/Library/BaseLib/BaseLibInternals.h | 42 -----------------------
>  MdePkg/Library/BaseLib/SafeString.c       |  8 ++---
>  MdePkg/Library/BaseLib/String.c           | 35 ++++---------------
>  4 files changed, 51 insertions(+), 74 deletions(-)

I have no comment on the code, but please change the subject line to:

  MdePkg/BaseLib: introduce CharToUpper() and AsciiToUpper() publicly

or something similar.

Thanks,
Laszlo