From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by mx.groups.io with SMTP id smtpd.web11.1849.1582178483125539192 for ; Wed, 19 Feb 2020 22:01:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ojM30eJ2; spf=pass (domain: gmail.com, ip: 209.85.214.196, mailfrom: newexplorerj@gmail.com) Received: by mail-pl1-f196.google.com with SMTP id j7so1120230plt.1 for ; Wed, 19 Feb 2020 22:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=NG9rf4VREqODwmpzE0DCFZYr/qTK8Rc1TNBMXU3Ecd0=; b=ojM30eJ2rOrK51/zkMX++hwJdKwsgNsvOnEF4ShJcPFPHe935JjFoGeaKLVtYRRGJO mJHTbTHVM+if1cdDrHvVboqQGbEEbtGYU6yrS/VaMO28lJyA3Vk2rQKix15jQqhrvcBr 9ytSTgZJcwIz8zo2Drso3fuwcrGQENjzU4L9cEa9J4vZejzsHXh4zT+mfH/HJedG/O0l yH6wiirUAYrqQgOV42LIWh+IiPRzApwY4YoYKWkK3luWOGpJrq3aQUKM7yBVHtmNLLgW 66/DISD9iqJ/Eapg5SEAzNxrlnTb1aABHSrXmYttsWZXkFYJJYaZ/l1wkXvzyZLxDafr kzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NG9rf4VREqODwmpzE0DCFZYr/qTK8Rc1TNBMXU3Ecd0=; b=J4D31n6rTC5K9Zlg8bKSsIzaodsGP1/6iVRt8nDSt6/+mOPiOOwmYW9skP7ICR/POs 8y53rEDxQxyS4mYcPZhNgLXr+lg9dnAyOEkh3qCIkZZSGGvJViCKxqV2Ud0mRSeXtA2t h4YTPlh8NirZ7j+24Raqcszelt2GKdEPoLU6e9gOMawKwHXMr8FH3VrWinjy1bMS7boS Gt497lrIq9lLgf7hKPTdmLQZIWNBiH0h56Vav9i4Fq1Pbe5TOdKmL9pDtrafNfsAts02 AQPJYRP4NgyTTXWgfKkhGgyV5uyMASM57/NzX0cvgmTbhKJaw5kUMLhmsU2sj4k5H/0v CDoQ== X-Gm-Message-State: APjAAAVwyF45z28NFG4wcsqfzPdBqOLS+edNpkdvUtUY1apj2X1JeolU oVvJvYcYSjOx+We0/1wqOoHxjeFXOcA= X-Google-Smtp-Source: APXvYqw6gEEAApyX63wY9oywTKryFpoE2F1tZk4Pe3zbBitfRSzrVTMB3JmKlF8jm040CWcp6FgVkA== X-Received: by 2002:a17:90a:8001:: with SMTP id b1mr1662210pjn.39.1582178482233; Wed, 19 Feb 2020 22:01:22 -0800 (PST) Return-Path: Received: from localhost.localdomain ([223.104.4.131]) by smtp.gmail.com with ESMTPSA id h7sm1746908pfq.36.2020.02.19.22.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 22:01:21 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [PATCH] MdeModulePkg/Application: Overflowed Array Index Date: Thu, 20 Feb 2020 13:59:13 +0800 Message-Id: X-Mailer: git-send-email 2.17.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2272 Index should be off-by one than size of array, so when check mUsbTypeString, the max index should less than size of array. Signed-off-by: GuoMinJ --- .../Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c index 0f7163160b..f8afcd6f96 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c @@ -508,7 +508,7 @@ UsbTypeToString ( IN EFI_USB_SMI_TYPE Type ) { - if (Type >= 0 && Type <= ARRAY_SIZE(mUsbTypeString)) { + if (Type >= 0 && Type < ARRAY_SIZE(mUsbTypeString)) { return mUsbTypeString[Type]; } else { AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Type); -- 2.17.1