Re: [edk2-devel] [PATCH v3 0/6] SEV Encrypted Boot for Ovmf

["Laszlo Ersek" <lersek@redhat.com>]

On 12/03/20 15:27, James Bottomley wrote:
> On Thu, 2020-12-03 at 13:26 +0100, Laszlo Ersek wrote:
>> Hi James,
>>
>> On 11/30/20 21:28, James Bottomley wrote:
>>> v3:
>>>
>>> - More grub and boot stripping (I think I got everything out, but
>>>   there may be something that strayed in the boot panic
>>> resolution).
>>> - grub.sh tidy up with tabs->spaces.
>>> - Move the reset vector GUIDisation patch to the front so it can be
>>>   applied independently
>>> - Update the .dsc and .fdf files for variable policy
>>
>> In preparation for submitting the github PR for merging this series,
>> I first ran PatchCheck.py locally.
>>
>> It doesn't like that I converted "OvmfPkg/AmdSev/Grub/grub.cfg" to
>> LF, in addition to "OvmfPkg/AmdSev/Grub/grub.sh".
>>
>> PatchCheck.py recognizes the ".sh" suffix, so it's not complaining
>> about "OvmfPkg/AmdSev/Grub/grub.sh". But, the config file is a
>> problem.
>>
>> Can you please confirm that grub works fine if the config file has
>> CRLF line terminators? Because then I'll just convert the config file
>> back to CRLF, and merge the series.
> 
> I converted the entire file with unix2dos and grub does seem to be fine
> with the CRLF line endings (probably because it wants to be a boot
> loader beyond linux), so I think converting the file to CRLF is the
> right way to go.

I submitted PR <https://github.com/tianocore/edk2/pull/1175>, but it was
rejected due to ECC failures.

I think we all need to have a serious talk about ECC. I'll send a
separate email.

I'm really sorry.
Laszlo