From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.7189.1607042829297563944 for ; Thu, 03 Dec 2020 16:47:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e4RAyxD/; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607042828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DcERNKABUjBCYV06qHKxOcHdkE147dXaZxRNIN41/lo=; b=e4RAyxD/b53eyhBi4zc1kht55Hsw+GVi9SWJRkijqWxYHP6RvYBguo2/AouBEveK0zJ6oI xBzBAuIoAVk05bIgV0WTFFJRfXe8+ObVppnNW+AGDZ6/esARg2Ef09BGIuXg6UfgKk0vyq Rif3OAPILvJ3yYys/rcULu8RmTD4Pm4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-YCAxb4nUOzSFjop8-sFL2A-1; Thu, 03 Dec 2020 19:47:05 -0500 X-MC-Unique: YCAxb4nUOzSFjop8-sFL2A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23A0E1005513; Fri, 4 Dec 2020 00:47:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-157.ams2.redhat.com [10.36.114.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9F4B60BFA; Fri, 4 Dec 2020 00:46:59 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 0/6] SEV Encrypted Boot for Ovmf To: devel@edk2.groups.io, jejb@linux.ibm.com Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" , Jordan Justen , Ard Biesheuvel References: <20201130202819.3910-1-jejb@linux.ibm.com> <0805f171-b5c2-a556-3e64-c700aaf06d85@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 4 Dec 2020 01:46:58 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/03/20 15:27, James Bottomley wrote: > On Thu, 2020-12-03 at 13:26 +0100, Laszlo Ersek wrote: >> Hi James, >> >> On 11/30/20 21:28, James Bottomley wrote: >>> v3: >>> >>> - More grub and boot stripping (I think I got everything out, but >>> there may be something that strayed in the boot panic >>> resolution). >>> - grub.sh tidy up with tabs->spaces. >>> - Move the reset vector GUIDisation patch to the front so it can be >>> applied independently >>> - Update the .dsc and .fdf files for variable policy >> >> In preparation for submitting the github PR for merging this series, >> I first ran PatchCheck.py locally. >> >> It doesn't like that I converted "OvmfPkg/AmdSev/Grub/grub.cfg" to >> LF, in addition to "OvmfPkg/AmdSev/Grub/grub.sh". >> >> PatchCheck.py recognizes the ".sh" suffix, so it's not complaining >> about "OvmfPkg/AmdSev/Grub/grub.sh". But, the config file is a >> problem. >> >> Can you please confirm that grub works fine if the config file has >> CRLF line terminators? Because then I'll just convert the config file >> back to CRLF, and merge the series. > > I converted the entire file with unix2dos and grub does seem to be fine > with the CRLF line endings (probably because it wants to be a boot > loader beyond linux), so I think converting the file to CRLF is the > right way to go. I submitted PR , but it was rejected due to ECC failures. I think we all need to have a serious talk about ECC. I'll send a separate email. I'm really sorry. Laszlo