From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mx.groups.io with SMTP id smtpd.web10.65.1616090846538499700 for ; Thu, 18 Mar 2021 11:07:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tlCWyNCm; spf=pass (domain: gmail.com, ip: 209.85.214.174, mailfrom: kuqin12@gmail.com) Received: by mail-pl1-f174.google.com with SMTP id o2so1701146plg.1 for ; Thu, 18 Mar 2021 11:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=2yHl1tLNIW7l81PM4UyO5MlZ13eCvhpb9Dpe6ESTfZc=; b=tlCWyNCmaBKhu8xauk+Uv40YjmFtmdb6Hom/+yO6w8kLHGBd1o7cJ0WerpzTV2SRHh GuvV5OnFj6lCEiQMTYWKgYpp+mCB9gLYGXNmeWrVbpDM9yZCJzYZ1rnGJYXq4QYVhHfs cplOi9WpqE31qtSwkVk1zppRKUrrdGX5YgF5V3H0gHgODErF+veOWdQAwtsz4Xt6LNbC OYaKtMUlQAsQsMaMDMANhJOUUkCJDMDXPg9fSnmUb9vfennGyGY+AGpJURClLQCnxos2 ZioBc1gFmJ8RGify4STJAmPIQwHb6TIkZYaTRIGRgaNl/MzMH7NhyV5Qm6zHIJD2ppnJ c6kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2yHl1tLNIW7l81PM4UyO5MlZ13eCvhpb9Dpe6ESTfZc=; b=ZV3SE6cQsETz4SCpdRkqm/0uIzZA3WAyL7U3SWIThgjV6JNRsI1/XZNMG2MT2YUEi1 xuXG1cE1jRZlSTuz8bMv3CHg7J17neusrRKah8jYWd3iOoB5uNAt62NSHP2CS9EEIBSp RHiUfGWKrJ8WKdkcz+icWKQVKCRzCkgouuKhcK3UO6YZyD8yLj+yZah2hcyVFs6Ow72P 98yFM6afS+FSKBZCt00vK3a4T9a3sIwi13K0UYD/4e4CzwtV4VF+4K1AlGUMDf83WKjZ +lV+PCoZj7nTieQyZOFaxfw5CXdlqDSPQJLRujRSDxi+sJHoeRFsf44UlY0yRHEdPhdo GGsg== X-Gm-Message-State: AOAM532e7fHbaDaVMN0qn9i3yVLz8Ij7Qll9jNrQUQNYgXgadbhMm7ZE XRhLFa+zGqpUAGLzU4W8ItQ= X-Google-Smtp-Source: ABdhPJyAh/3oOTnLOMTAYMVsIriiGmNv637QNcRehPFaITmzl1QVF+6RNJsjWzcIn+cI0MGF7cs1uQ== X-Received: by 2002:a17:90b:307:: with SMTP id ay7mr5597138pjb.110.1616090845901; Thu, 18 Mar 2021 11:07:25 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id j35sm3016154pgj.45.2021.03.18.11.07.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 11:07:25 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe To: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm References: <20210316181038.1413-1-kuqin12@gmail.com> <166CE5173C17A517.7039@groups.io> From: "Kun Qin" Message-ID: Date: Thu, 18 Mar 2021 11:07:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <166CE5173C17A517.7039@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard/Leif, Could you please review the change and let me know if you have any feedback when there is chance? I can drop the patch if this package is not supported/maintained any more. Please let me know how you would like to proceed. Thanks in advance. Regards, Kun On 03/16/2021 11:10, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 > > This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to > resolve new dependency by VariableSmmRuntimeDxe. The library interface > is consumed by variable module to better support variable runtime cache > feature. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > > Signed-off-by: Kun Qin > --- > > Notes: > v2: > - No review, no change. > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 0a11b796cca5..acaa4cd90fc5 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -49,6 +49,8 @@ [LibraryClasses] > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > !endif > > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > + > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >