From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mx.groups.io with SMTP id smtpd.web08.21804.1643566987851411729 for ; Sun, 30 Jan 2022 10:23:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=fm1 header.b=4zfDjRhS; spf=pass (domain: bsdio.com, ip: 66.111.4.221, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 0EA8E58029E; Sun, 30 Jan 2022 13:23:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 30 Jan 2022 13:23:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=YF/LwhTCyPkMnW AtHPQxuKTV7HxgCAfXs+/2z5sIgHY=; b=4zfDjRhSDR0p9SYw1Q0UnxRqix+XLE NWeq72KftFxZEftkmijoR64RnkfW5gG+68DQJbYbS0YuSslDeB+w4Ih31Ubo5O20 UVdKlcPT+mzOloW8pRnN3TPPqnKNDfZ2SflpmJUO/aE0Uzl0eWdKzPkFgZOxCPOS zbbdnhzEpQh3nN29P7Q3uJXi+ePJqXpTfOHC8H/JuzItujiDiLtQNYQQrxxv+zxe 4n6fUC85xz6bxzVM3vBqfHeHkk0L9Ywo215fr9qOMnNCQWU9FrJcqzonvLRKHLCq i756EJV8NepcmIlVK7WSTa8VeoADEdGAQfvwafZRC3XJbYcuWRFjSFiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=YF/LwhTCyPkMnWAtHPQxuKTV7HxgCAfXs+/2z5sIg HY=; b=MY++bB+etWXkOm8AZC53sst1pPSKvbqRorec4l6hqKGLOYOjrWU7QQ1Hs Jh7QEyf+PXz3EBSyHdq+0SPyUw/DNoWJWMty3zigbFApuOgCQpM+4HAJicSZ4ww6 d+GnIJvoiHqkT8uH3nFSje0t7oMSRts+K8cuOcwmMiS40Xkey3/d8KrCLU2/wQ26 P4rYyxwmJX+4B/bt9i4MrBkUazis0rGRdg8c3rDKg9/f+dfZ8CGi2q8coj3L50BK DOOcc0Ry6Td6ojH8hbpZLRGnkSH9fbynFIPwOuJqiS6Tyu4b3N/SntE0Se7Lj3FQ +a7ThGCQBFRHVEYXleP5M5lZip/gg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrfeelgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepleduvedtledtvedvuedugeeuudeiiedtueduvdffueekfeejffduvdetjeev ffdvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jan 2022 13:23:05 -0500 (EST) Message-ID: Date: Sun, 30 Jan 2022 11:23:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning To: devel@edk2.groups.io, brijesh.singh@amd.com Cc: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann References: <20211213193839.143953-1-brijesh.singh@amd.com> From: "Rebecca Cran" In-Reply-To: <20211213193839.143953-1-brijesh.singh@amd.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I'm still seeing this error when building using XCode 13.2.1, so I guess this patch hasn't been committed yet. -- Rebecca Cran On 12/13/21 12:38 PM, Brijesh Singh via groups.io wrote: > The XCODE5 reported the below warning > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized use occurs here > Compacted > ^^^^^^^^^ > > Initialize the 'Compacted' variable to fix the warning. > > Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID values) > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Michael Roth > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > index a40a31f7c275..ff367411cc59 100644 > --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > @@ -1872,6 +1872,7 @@ GetCpuidFw ( > UINT32 XSaveSize; > > XssMsr.Uint64 = 0; > + Compacted = FALSE; > if (EcxIn == 1) { > /* > * The PPR and APM aren't clear on what size should be encoded in