From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B29F7211E2EEF for ; Thu, 21 Mar 2019 11:58:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 51657308421A; Thu, 21 Mar 2019 18:58:07 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-143.rdu2.redhat.com [10.10.120.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90A595C688; Thu, 21 Mar 2019 18:58:05 +0000 (UTC) To: Zhichao Gao , edk2-devel@lists.01.org Cc: Jordan Justen , Ard Biesheuvel , Liming Gao , Sean Brogan , Michael Turner , Bret Barkelew References: <20190321140459.18304-1-zhichao.gao@intel.com> <20190321140459.18304-10-zhichao.gao@intel.com> From: Laszlo Ersek Message-ID: Date: Thu, 21 Mar 2019 19:58:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190321140459.18304-10-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 21 Mar 2019 18:58:07 +0000 (UTC) Subject: Re: [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 18:58:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/21/19 15:04, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 > > Add new APIs' implementation (DebugVPrint, DebugBPrint) > in the DebugLib instance. These APIs would expose print > routines with VaList parameter and BaseList parameter. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 106 +++++++++++++++++++++- > 1 file changed, 101 insertions(+), 5 deletions(-) This v4 patch is identical to v3. When you repost a series in order to update a subset of the patches, you should please pick up the feedback tags from the previous review session for those patches that you do *not* change. This is explained here, for example: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-26 https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-28 This makes a huge difference for reviewers -- it costs you a bit of time, but it saves reviewers a lot more time. For example, the present patch has not been changed from v3 to v4, and I gave my A-b in the v3 review session. Therefore you should have edited the commit message on this patch, to include my A-b, for the v4 posting. Either way, I can give it again here. Acked-by: Laszlo Ersek Thanks Laszlo