Re: [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 2/11/18 4:23, yuchenlin@synology.com wrote:
> From: yuchenlin <yuchenlin@synology.com>
> 
> In this series, replace the original vmsvga driver to Bochs
> interface.
> 
> Simply revert vmsvga driver implementation. After it, use Bochs
> interface for initializing vmsvga.
> 
> Because of the PCI BARs difference between std vga and vmsvga.
> We can not simply recognize the "QEMU VMWare SVGA" as the
> QEMU_VIDEO_BOCHS_MMIO variant.
> 
> BAR  |    std vga     |  vmsvga
> ---------------------------------
> 0    |   Framebuffer  | I/O space
> 1    |   Reserved     | Framebuffer
> 2    |   MMIO         | FIFO
> 
> To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA,
> and use it for:
> 
> (1) Get framebuffer from correct PCI BAR
> (2) Prevent using BAR2 for MMIO
> 
> We have tested on qemu before and after commit 104bd1dc70 and all
> worked.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: yuchenlin <yuchenlin@synology.com>
> 
> Changelog:
> v1 -> v2
> * use 'else' clause (Thanks Philippe).
> * add more comment in revert patches (Thanks Philippe).
> * reorder the revert patches, we should revert the last commit first.
> * use correct framebuffer to ClearScreen.
> * revert VMWare svga definitions.
> 
> yuchenlin (5):
>    Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF
>      file"
>    Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"
>    Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port
>      I/O."
>    Revert "OvmfPkg: VMWare SVGA display device register definitions"
>    OvmfPkg: simply use the Bochs interface for vmsvga

FWIW Patches 1-4:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Patch 5 (not yet merged) is still on my TODO because I want to run 
detailed testing.