From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.66; helo=mail-wm1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C56621160A36 for ; Mon, 12 Nov 2018 06:16:47 -0800 (PST) Received: by mail-wm1-f66.google.com with SMTP id v70-v6so7871537wmd.1 for ; Mon, 12 Nov 2018 06:16:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RidAudlxNJMZOlypZ96i/X/YLJTufTTRaI7uSZ+Nbxo=; b=HPa3zeA+W0yLFzZ5OKepC33u695Mj1mqBdSpk9mEODJzG+NK6XILJMjlWbOlkYHKzg aovgO/WO0POOg5XfP4ZfPAribeDYKzruIwfIjuQAWdMGhrUukE//sOgcSDmrXjEvn5g8 PLasVn/M8kY9caH7orDTCEGuqKH7cs5n6Cook9Qgw/giVulPh9VjgajxkmEw8b3dpOLm LRaKqgJihscoc+7hNdJzCjZiUJAgAafTwbqeWAVmSHieiPqZVdQaKRBX7dBX2emxP6yc qJpeU7VCdzbZBjg3XeSPxgjqHme1dSzZB5yoAFNzyJk63uDX4caxIEA2Nk18S6pk/Xr2 6Rmw== X-Gm-Message-State: AGRZ1gLtNZYrn6vbwljtSJ4SccYDOvWk4MwSmr1qNqubBTmyYd+f8LqB 3zV4LE0mquOrX5QQa5hiWRMK8g== X-Google-Smtp-Source: AJdET5coMh0j0fZACjfZaAA+1PV2mnaVoqG6BEQ2CucDT4+yHWCirTV6cYBJI27ftxz3WDkIUDHcbA== X-Received: by 2002:a1c:410a:: with SMTP id o10-v6mr7943492wma.19.1542032205672; Mon, 12 Nov 2018 06:16:45 -0800 (PST) Received: from [192.168.1.36] (2.red-83-59-163.dynamicip.rima-tde.net. [83.59.163.2]) by smtp.gmail.com with ESMTPSA id l186-v6sm24028982wma.13.2018.11.12.06.16.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Nov 2018 06:16:44 -0800 (PST) To: yuchenlin@synology.com, edk2-devel@lists.01.org Cc: jordan.l.justen@intel.com, lersek@redhat.com, ard.biesheuvel@linaro.org, anthony.perard@citrix.com, julien.grall@linaro.org, phil@philjordan.eu, kraxel@redhat.com References: <20181102032402.19686-1-yuchenlin@synology.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 12 Nov 2018 15:16:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181102032402.19686-1-yuchenlin@synology.com> Subject: Re: [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 14:16:47 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 2/11/18 4:23, yuchenlin@synology.com wrote: > From: yuchenlin > > In this series, replace the original vmsvga driver to Bochs > interface. > > Simply revert vmsvga driver implementation. After it, use Bochs > interface for initializing vmsvga. > > Because of the PCI BARs difference between std vga and vmsvga. > We can not simply recognize the "QEMU VMWare SVGA" as the > QEMU_VIDEO_BOCHS_MMIO variant. > > BAR | std vga | vmsvga > --------------------------------- > 0 | Framebuffer | I/O space > 1 | Reserved | Framebuffer > 2 | MMIO | FIFO > > To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA, > and use it for: > > (1) Get framebuffer from correct PCI BAR > (2) Prevent using BAR2 for MMIO > > We have tested on qemu before and after commit 104bd1dc70 and all > worked. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: yuchenlin > > Changelog: > v1 -> v2 > * use 'else' clause (Thanks Philippe). > * add more comment in revert patches (Thanks Philippe). > * reorder the revert patches, we should revert the last commit first. > * use correct framebuffer to ClearScreen. > * revert VMWare svga definitions. > > yuchenlin (5): > Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF > file" > Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" > Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port > I/O." > Revert "OvmfPkg: VMWare SVGA display device register definitions" > OvmfPkg: simply use the Bochs interface for vmsvga FWIW Patches 1-4: Reviewed-by: Philippe Mathieu-Daudé Patch 5 (not yet merged) is still on my TODO because I want to run detailed testing.