From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::242; helo=mail-pl0-x242.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x242.google.com (mail-pl0-x242.google.com [IPv6:2607:f8b0:400e:c01::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D4DDF210E3DD1 for ; Thu, 9 Aug 2018 05:15:44 -0700 (PDT) Received: by mail-pl0-x242.google.com with SMTP id w3-v6so2493893plq.2 for ; Thu, 09 Aug 2018 05:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=ifftXf/MqEGL/sQzb+AN964LIMYWJAC2xrDHJgW304o=; b=f7r91Uiu9XMq+6ZINACqsl66r8gqSbTeOPkhvbUe/luSHRIqmFna8V/1S6K3czk5tt bhuxHMMhaomZ9oI5rzDHQPg9JufcQJXYMhI3R09+feV+O6SSufa593o0FebPJ5JuA6j8 LKyjfAV6Lv0US2wMLuNbaqXcOk4O1biYLewAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=ifftXf/MqEGL/sQzb+AN964LIMYWJAC2xrDHJgW304o=; b=C6Ka+enZb3gyNg2BCgP13CvuO7X0J3rvALynSEqhXFZSfPnsULlNyD+wKaLY5C5Qbm rB0mnEgxT4b2FEpQI9rsGKoO4OUaTbYoBTrQpCryQldExNWH/td5IgWEoIgAXnur3hse X4VAUIVMTp89aJ4vWGM2J8gxVvw9Wd+/3rb7EmzKNZLvUBTG7UVG0jOU2s9EyHZeGfyN gRc/fi/a1zKY/PeG6PtEmYIPysT/j2pZ8BuvRenkjZqTmF+xgttSC8IlgOLQMePgVFIw 7XIucTU/BjJdxRfvzgBQauGVPYBLORH04GbZSTy1M4OoD3c32xOqyN5D+KlRzEEYcjN1 G20Q== X-Gm-Message-State: AOUpUlHwvGLgQSuW11NwqwglNJ4Abf9yGgEHFivFxwZGZW55RUwAXSZy bFcEEWNrt9N9MSl9/gyukyEvyA== X-Google-Smtp-Source: AA+uWPzQVZaGITqDxDP3m5d1vuhkTWH+M5fuPuMKDGOMqJtTL59yf4nLrF29mcENpMaBz/kvNA8HBA== X-Received: by 2002:a17:902:b40c:: with SMTP id x12-v6mr1887929plr.163.1533816944462; Thu, 09 Aug 2018 05:15:44 -0700 (PDT) Received: from [10.199.0.182] ([64.64.108.224]) by smtp.gmail.com with ESMTPSA id y18-v6sm8407471pfl.90.2018.08.09.05.15.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 05:15:43 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, ZhenYao , Heyi Guo References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-34-ming.huang@linaro.org> <20180804151432.jc45us7rfyz6bytm@bivouac.eciton.net> From: Ming Message-ID: Date: Thu, 9 Aug 2018 20:15:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180804151432.jc45us7rfyz6bytm@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 33/38] Silicon/Hisilicon/D06: Modify for close slave core clock. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 12:15:45 -0000 Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit ÔÚ 8/4/2018 11:14 PM, Leif Lindholm дµÀ: > On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote: >> From: ZhenYao >> >> When BIOS booting, the power consumption is too high, so need close >> some clusters clock that don't work to reduce power consumption. > > On the one hand: should this not be handled in ARM-TF? This can no be handled in TF and should be handled in Sec phase. > What if (during development) we load a bad EDK2 image? Sorry, I don't understand really. > >> The implementation of functions is in edk2-non-osi. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: ZhenYao >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo >> --- >> Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h >> index ec2b9a36e7..cc60e213de 100644 >> --- a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h >> +++ b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h >> @@ -102,5 +102,8 @@ VOID PlatformEventBroadcastConfig(VOID); >> UINTN GetDjtagRegBase(UINT32 NodeId); >> VOID LlcCleanInvalidateAsm(VOID); >> VOID PlatformMdioInit(VOID); >> +VOID CloseClusterClock(UINTN CpuClusterBase); > > The opposite of Enable is Disable. So Could this be DisableClusterClock? Yes, this name is better. > >> +VOID EnableClusterClock(UINTN CpuClusterBase); >> +VOID CloseSktClock (UINT8 Skt); > > Disable? > Also, Socket, not Skt. OK, modify it in v2. > > / > Leif > >> >> #endif >> -- >> 2.17.0 >>