Re: [edk2-devel] [PATCH 1/1] NetworkPkg/ArpDxe: Recycle invalid ARP packets(CVE-2019-14559).

["Laszlo Ersek" <lersek@redhat.com>]

On 02/13/20 00:53, Armour, Nicholas wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
> 
> This patch triggers the RecycleEvent for invalid ARP packets.
> Prior to this, we would just ignore invalid ARP packets,
> and never free them.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Nicholas Armour <nicholas.armour@intel.com>
> ---
>  NetworkPkg/ArpDxe/ArpImpl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/NetworkPkg/ArpDxe/ArpImpl.c b/NetworkPkg/ArpDxe/ArpImpl.c
> index 9cdb33f2bd66..09fc8811f125 100644
> --- a/NetworkPkg/ArpDxe/ArpImpl.c
> +++ b/NetworkPkg/ArpDxe/ArpImpl.c
> @@ -125,6 +125,7 @@ ArpOnFrameRcvdDpc (
>    Head->OpCode    = NTOHS (Head->OpCode);
>  
>    if (RxData->DataLength < (sizeof (ARP_HEAD) + 2 * Head->HwAddrLen + 2 * Head->ProtoAddrLen)) {
> +    gBS->SignalEvent (RxData->RecycleEvent);
>      goto RESTART_RECEIVE;
>    }
>  
> 

Please put a space character in the subject line, before the
"(CVE-2019-14559)" part.

Please also drop the trailing dot.

Thanks
Laszlo