From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web12.5909.1581925839552423456
 for <devel@edk2.groups.io>;
 Sun, 16 Feb 2020 23:50:39 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Nf7Fn6Ip;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1581925838;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bzFDHg/ko+kHvQ7Ml1MZ8QS/xWazcnyvrxe8l10Qdm8=;
	b=Nf7Fn6IpqjIbGvfT82FQQv3m3tyjo3KxIbmHZhMWaNxGVEVgoqV8hnKLdGoyofgoY0zu2Y
	HN1kFLXJ6diNRrcyW6mQyUCGYOibRcgl0VmzrjVqO1wo5U+fkpntz6HiuJ1Ppk26u+oZIU
	vwkqitmvjjCV/ErPmYdAWDyxEjz2QC0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-43-Ava4IDXgNJyp83O2ygEkOg-1; Mon, 17 Feb 2020 02:50:30 -0500
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E875A18C8C0F;
	Mon, 17 Feb 2020 07:50:28 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-195.ams2.redhat.com [10.36.116.195])
	by smtp.corp.redhat.com (Postfix) with ESMTP id B1E8B1001B09;
	Mon, 17 Feb 2020 07:50:27 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 1/1] NetworkPkg/ArpDxe: Recycle invalid ARP packets(CVE-2019-14559).
To: devel@edk2.groups.io, nicholas.armour@intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>,
 Maciej Rabeda <maciej.rabeda@linux.intel.com>,
 Siyuan Fu <siyuan.fu@intel.com>
References: <cover.1581551021.git.nicholas.armour@intel.com>
 <bcb81b4d2751ce483cb06b4190046f9daa4fcb5e.1581551021.git.nicholas.armour@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <a31f43ed-da25-2786-1294-75327d98fb3d@redhat.com>
Date: Mon, 17 Feb 2020 08:50:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <bcb81b4d2751ce483cb06b4190046f9daa4fcb5e.1581551021.git.nicholas.armour@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-MC-Unique: Ava4IDXgNJyp83O2ygEkOg-1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 02/13/20 00:53, Armour, Nicholas wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
> 
> This patch triggers the RecycleEvent for invalid ARP packets.
> Prior to this, we would just ignore invalid ARP packets,
> and never free them.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Nicholas Armour <nicholas.armour@intel.com>
> ---
>  NetworkPkg/ArpDxe/ArpImpl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/NetworkPkg/ArpDxe/ArpImpl.c b/NetworkPkg/ArpDxe/ArpImpl.c
> index 9cdb33f2bd66..09fc8811f125 100644
> --- a/NetworkPkg/ArpDxe/ArpImpl.c
> +++ b/NetworkPkg/ArpDxe/ArpImpl.c
> @@ -125,6 +125,7 @@ ArpOnFrameRcvdDpc (
>    Head->OpCode    = NTOHS (Head->OpCode);
>  
>    if (RxData->DataLength < (sizeof (ARP_HEAD) + 2 * Head->HwAddrLen + 2 * Head->ProtoAddrLen)) {
> +    gBS->SignalEvent (RxData->RecycleEvent);
>      goto RESTART_RECEIVE;
>    }
>  
> 

Please put a space character in the subject line, before the
"(CVE-2019-14559)" part.

Please also drop the trailing dot.

Thanks
Laszlo