From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web09.17423.1611687897411565526
 for <devel@edk2.groups.io>;
 Tue, 26 Jan 2021 11:04:57 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M1iYbBCD;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1611687896;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LQUkjQHot9tY/wqDCgmmGK9DwnkFgIA/d2Yjo+9cGZI=;
	b=M1iYbBCD3dicNnqDLnwDEvdFtTBM1sCFY32LE2Wk2S/J4YDY6fj0w2sePMC6MX9chTXmZb
	P7piA630alrP3O/wqLdT1fc2cMJqSQ1+ABY+aaSZYTEjz3RqA8vC7gAd8C+TmMOg7Wr3FU
	F6x91OlsP7+5fj2cGYV6LP3w5Ocis+s=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-491-FO8PbZzINlaRlvp58jjv5g-1; Tue, 26 Jan 2021 14:04:52 -0500
X-MC-Unique: FO8PbZzINlaRlvp58jjv5g-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16ADC8030A7;
	Tue, 26 Jan 2021 19:04:51 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-219.ams2.redhat.com [10.36.112.219])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 8071B10013C1;
	Tue, 26 Jan 2021 19:04:49 +0000 (UTC)
Subject: Re: [PATCH v5 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic
From: "Laszlo Ersek" <lersek@redhat.com>
To: Ankur Arora <ankur.a.arora@oracle.com>, devel@edk2.groups.io
Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Aaron Young <aaron.young@oracle.com>
References: <20210126064440.299596-1-ankur.a.arora@oracle.com>
 <20210126064440.299596-2-ankur.a.arora@oracle.com>
 <3f3fd01d-78a9-315c-85e3-b5788b8d6489@redhat.com>
Message-ID: <a32f372d-bf59-750c-b1de-079ba1c59ff6@redhat.com>
Date: Tue, 26 Jan 2021 20:04:48 +0100
MIME-Version: 1.0
In-Reply-To: <3f3fd01d-78a9-315c-85e3-b5788b8d6489@redhat.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/26/21 20:01, Laszlo Ersek wrote:

> (1b) Similarly, in the parameter comments, "to be plugged" is wrong. I
> suggest copying the parameter descriptions from
> QemuCpuhpCollectApicIds():
> 
>   @param[out] PluggedApicIds   The APIC IDs of the CPUs that have been
>                                hot-plugged.
> 
>   @param[out] PluggedCount     The number of filled-in APIC IDs in
>                                PluggedApicIds.

(Of course, in this location, the parameters are [in], not [out].)

Thanks
Laszlo