From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53FE0941D8E for ; Fri, 27 Oct 2023 21:31:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=celUiajvj52z4RqOZip98xblAyYC5cPVd4rFALr441U=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698442273; v=1; b=myolrJTYwRenQTbtdRFO+6iZguCLWdCVJlFeWXUc6DgFEpBjUi9PuGxthA8KiGn83XoI852Q dZpCqrS1z1I4eW8mcdYXoIpuOQGyoOuxyL5RBf5QmRbDoonpVy5zeTI/r8VvtdOklgjeFHEvkKU xx67FTZj/gTug7OfHPhVk5hA= X-Received: by 127.0.0.2 with SMTP id SDlYYY7687511xjZcqoXmBLA; Fri, 27 Oct 2023 14:31:13 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.87]) by mx.groups.io with SMTP id smtpd.web10.23457.1698442272166686197 for ; Fri, 27 Oct 2023 14:31:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=axvweAgaUxtY/j5L3dZsqozl2FOLW+Ah+b2RQF9oiKOEQGyxfQHoHqd8qyauiMkL1Bn37OVfXB/sibiCdgQWx1h2Hx2fw3K/jbdrX5tkHdrLMs/r1v5oPUozm0AAoUYliElWoYV/5/JrpjsVVd1YrOW6AeP4Djf+gUNPyrBT1soKtSP01PKHM9yDh/wh95gaDNPiAlRYyjiZCJfH6vJBjVEuA8ZA1nzYgus/hkj1un0XWsf/48gidPZl2bbGgUvFH+FuNaiMy8CP3H98xmN7m7by3WxBM7HlxGzLf4tqJOZp6IVJzJiA6zpLf+9moc+KHM9z/Z8CMlIfDg/oZQva0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=li906F6k1eSJuEcKU129uY7T2/ag0G6e1E5ntl5mjxM=; b=D3S2LHIFLmmE4B68trCp4WD4VUh9ddpKB/T04ICwKDZgCdW9uDocmW4hZnKjg8RJEwzWUeUUS5KO/kJxuliZTMiym8k0zQkQ/a9fMKZAR/N9ejKfTrS+3ypINKTV7e93gkthUXV8LLF15eKy7aMLSE8O2yUPIk7ZMaPU3NliWqwhMHnlTzwp4AWOLjJF5NRfU0tBAyw6g/FO7WLloIQ0GCxfZejOjt2TErA1kj9njElUtlWUkmxjKuzn+cLIqNLuxzDpqoRLf0kKO9Sz9vby9kec24Xz+6RvTGKp2ZxGS8hOGWUAG78yRNmBhx6qwwjqsQfsLJVtR+Y7tgKhr/ORSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by DS7PR12MB6215.namprd12.prod.outlook.com (2603:10b6:8:95::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Fri, 27 Oct 2023 21:31:08 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::e16e:d7f1:94ad:3021]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::e16e:d7f1:94ad:3021%7]) with mapi id 15.20.6933.024; Fri, 27 Oct 2023 21:31:08 +0000 Message-ID: Date: Fri, 27 Oct 2023 16:31:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev To: "Tan, Dun" , "devel@edk2.groups.io" , "leo.duran@amd.com" , "brijesh.singh@amd.com" , "Chang, Abner" , "michael.roth@amd.com" , "Attar, AbdulLateef (Abdul Lateef)" Cc: "Ni, Ray" , "Yao, Jiewen" References: <20231027054300.1382-1-dun.tan@intel.com> From: "Lendacky, Thomas via groups.io" In-Reply-To: X-ClientProxiedBy: CH5PR03CA0016.namprd03.prod.outlook.com (2603:10b6:610:1f1::28) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|DS7PR12MB6215:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dfbaeff-611d-41ef-ef9e-08dbd7340836 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: htay7pvo+ucIKFckzLEY2zpSIlS9BHUIScyF3p/zmfo5ZUTs8G7HvaAQUEuWJV5XeekXrzzFVS9sr47BnbzFMz0Kb7wL5hcqkeyrkPKu7KtGBbsWigoH8KtAMqdWmepAW6LsKVNawAEejwAkvWxxcE+nrrlqYSNg3sgIfMHotVVi5XrX/ABo7We2MHjvDHYcbrcudXUMPCtXNCrIAw299HgnP52p8i2Eszh4Xi6uJj1LnBZZU39zUo5nzGxvVQm1wYzbbOjAzEBWNVe0DOSIswamzxNZ4VoFgiqanm4YqTRHMYgZjFniwQuDzVYSb/JohBeN2qYePYcKzC6YZtragELHM7AdPUkmDA9Ckejz/2qkszVQCsxQIpYq6DduhEEKwy8aQFNr89RUPAwfoTumxohHK8swFaFhIgQg1tJVzTcm6WsEyan/E02S7hHwC8QOOTVqr1UtLnasyFiX0qhYZSvZuASIyJKcdYLexZc6u9J8vJyQZ9S1rUSfpU6NUI37SHbAqWezRD58bbHbbqnan2tMnI0YaudepNg/sbuotIcD6P1OHsaYx94zibUhMurEoRDnAen1gPWPje7C5lh7S9N38zx1crn26+uTPVmZiueasZWkTOOsu2T4urYi0BIzQUrOIY9HQbCDUeCSyvuddTY83N1l7sIl1OCtvc1WzlQ= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW44TjhPYkFFaUtvdW05WmhWOU5ia0ZXa3E5ZTg2aTlQR2RqS1ZQZ2ZnYWlC?= =?utf-8?B?N2luMnE5ZG95M1pWa0EvTHJjY0ZmNGxIQU5tRUJSNTIzSURnamUwcWwzck8z?= =?utf-8?B?YkQ0dnZnTkJ5Y0svZ2hIK3lJcGNtM0YxVlBkb1hVNER3eFpaQUVsbFR3TlhI?= =?utf-8?B?TktQNGRhemFTbHVudExqd0hEYzVZcmk1UHg0MiswenlYMnNLK215YUl6MXlX?= =?utf-8?B?dTFPKzgvU0x0OHptZ3pGNTJhREQ4bmZiMTJwaThxSEhaWlFOZ2R4N1VnYkQz?= =?utf-8?B?NWlqTDl3eDBXbjM4OERTODREY3JaTy8xRDZadjNSZHRua3BscGdyRU9abHVl?= =?utf-8?B?YkR3Q0h0WCtOQjhkbEZOS2F3aVJTbmxkNGYwYkhiVXhoR2c4aWM2RzBKZzQy?= =?utf-8?B?Rnd4N0NFNnZNTEVMeEt2dlYvdGxkRm9UZTcxTzZ4QVdKYnlTSjM4MFQxcm5u?= =?utf-8?B?R252YVZsSEgrLzJRQjh1WDZuVStOS1JkcVlyOFB4T1o0dDdtR01wSGNRUVVw?= =?utf-8?B?TDJrZWZkYVMzQXRPTTZqdTdGSXJkVkRPOEVNZWVBYjJ1Ynp2bkN4WGhMRk9x?= =?utf-8?B?a3Z6ZTkyODArWkVJYWZEdGVQcGxuaDFmKzg3VGZDTEtTUmxNdmVtN1VHdWE0?= =?utf-8?B?aW4vd3dXK0JFajIyWXM4YzZsZTRNenVMZ0VTelNpNXB0YzBmUWh6TStDeDVa?= =?utf-8?B?YUFPL1MwS1JpTGphSW95Sk1waGRqMVE5T3FoR0pvR3VoM25tVU1ZTzl5MFBy?= =?utf-8?B?aENGME9tZ3RYTXpBNHcyYVgyWnVDMVlXaE9qcFFwVlhaZXRISVN6YXpwNkZN?= =?utf-8?B?SXJGOTBmclVueFNqc0RjUGhMZDhSUjBldGsxU3hGUytKZytxdzBCeDVUU0U4?= =?utf-8?B?UFhJcnNVNnY0Tm8wYnhQSkE4RWJwUlJuK3dkMjN3c1RES0g3RzQ3cUxGMHNj?= =?utf-8?B?YUhjbmZCeUo2ZEpCTDVjS3p2LzN2M1dkZEtUd0U3RDM5T2xOZy9NQlRla2hk?= =?utf-8?B?bkxNVWJEUGwvenF1d2htQnV2bUVGWWc3dWlPbUxVVVMvL3g4anVFTFZTNmhn?= =?utf-8?B?NzMvbmFmYjVvSC84TG80Z2hhNklkaUFTQWZBWEczUi9jdmNuLy80eENwenR5?= =?utf-8?B?SlFUUjJCcmxLeG1wbGNKblpzRzNiZi84cklEcTE5WG5sc0l1SzdYVVN3YWw3?= =?utf-8?B?V2xKN2hQdmk3UVUxRzd2QUhlNS9WRTV2MHdCUDVJWll6ci9SUlpkeHJlOGdX?= =?utf-8?B?U21sbDFlaVRNSExsQXBocnREbnROVW9JZk0yd1pvbDZ6UEVUaTZXWXRNLzhI?= =?utf-8?B?alUvMzVDbTF0Z2FwTGhiaWdKd0JjR0hiR0pzRFZmRDVVQUNUeENZMW9ranNu?= =?utf-8?B?aW1JQ01WSU1WVHZBdXJFd0QveHJnZFYyQ1dLbW9vMFFPT2FnQVFVVkY2TEhE?= =?utf-8?B?aHNpR282RzBzKzRTQVhEKzlYYnE5S2diZUhSdDVacWNOaEdsU0F6cW9CM0Zy?= =?utf-8?B?TVhkd2NFa1Vkc21XNW45MG1sSHA4aXIvczhGektEOUtHWUJ6ZytnQjlKMk9H?= =?utf-8?B?NTFPVlZ4aTNwVWgxeUl0clNkZHh3ejQ4ZFp5eGU4b3VaTWdGemZhWWk3WDRh?= =?utf-8?B?b1RpTDhtdjhOVU40dmt3Q21BMjJIZXRrNzNvVHIveHJGL0pQNy9QZW9zUlNH?= =?utf-8?B?dU9veTVyU29vL2xSckFiL0Y0TVplbnl1WmV5c3RPNjh6ZzVyS3BSVVkzcmZs?= =?utf-8?B?K2tRZndFNDdpZ29KSXF1cjlnZkkzbkxYbitYTVE0bytZVjdLdTZmWHFHS0dm?= =?utf-8?B?NUdMbDBCU0crQlArWVZQYUh5UHZuNkU4cFhMVHliSTU2eVczL1hGS29MM1lN?= =?utf-8?B?NVVacWJWblJYUjJDTUFkaUdhUWwzaVJseGdBOFFQaC9iQjBGTGpiVmhhQWtH?= =?utf-8?B?UFQ1QlpTek8yUmxhamZoSDliMzdzWUsxU3hCRFdQRnNhV2M0Zk01cFF4MDg5?= =?utf-8?B?d1g4Yks3V1ZnSDcyYzVkWlRIQWI0SE0vL2ZBbHh1cW5NWTNwOHBJL2hIc3B3?= =?utf-8?B?ZS96alRESGt3ekdDbHA4akxBbWxBQm5sZEJIbzBsZ2c4dzJLZ1N4UXZEM0RO?= =?utf-8?Q?cC/fXIO6u+2+TJQAQpvNrToU+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9dfbaeff-611d-41ef-ef9e-08dbd7340836 X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 21:31:08.0744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eXO6y8wJUJWx15ZI12lqaArCMYuOnhzUlzV+rZ500PlPfh3k9JA4qkcYQrO75JqNO9rr77r0X8KvQ7PokauEQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6215 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Q1WYlqHawiBIqYX8UTM9mJgsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=myolrJTY; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/27/23 03:05, Tan, Dun wrote: > Hi all, >=20 > Could you please help to review this patch set? In this patch set, the Io= Lib instance BaseIoLibIntrinsic is modified to support AMD SEV feature and = the BaseIoLibIntrinsicSev is removed. > Also could you help to do a test on AMD processor to make sure that the S= EV feature still works good with this patch set? I was able to test SEV, SEV-ES and SEV-SNP guests successfully at each=20 step of the patchset. However, you are unrolling the string I/O for everyone, now, not just SEV= =20 guests. Is that acceptable to the community? I think there need to be=20 comments in IoLibFifo.c around the new code about why the access is=20 unrolled/looping so that someone down the road doesn't come along and try= =20 to use string I/O again. From a commit message standpoint, you have up to 74 characters per line=20 to use and I see most of your messages do not make use of that. Also, you= =20 use sev when it should be SEV. Using SEV will make grep'ing commit=20 messages simpler. Thanks, Tom >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: Tan, Dun > Sent: Friday, October 27, 2023 3:35 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibInt= rinsic and remove BaseIoLibIntrinsicSev >=20 > Thanks for the suggestion. > I'll update the test result once I finished the test. Also the abstract m= essage in this patch has been modified to mention that this patch should no= t be merged now. >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, October 27, 2023 3:07 PM > To: Tan, Dun ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibInt= rinsic and remove BaseIoLibIntrinsicSev >=20 > Here is my suggestion: >=20 > 1) Please perform the test to ensure the functional part is correct. >=20 > Without that, how can people know you are doing things right? >=20 > 2) If you do not run any test, before you send out patch, please call out= that clearly. > That is important to reminder the maintainer: Don't merge, even if it pas= s review. >=20 > Otherwise, once the review passed, the maintainer may merge it. > I don't think that is the intention. >=20 >=20 >=20 > Thank you > Yao, Jiewen > =20 >=20 >> -----Original Message----- >> From: Tan, Dun >> Sent: Friday, October 27, 2023 2:32 PM >> To: Yao, Jiewen ; devel@edk2.groups.io >> Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in >> BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev >> >> Hi Jiewen, >> >> Currently I'm working on the Tdx test. Since the patch set doesn't >> change the code logic when Tdx or SEV is enabled, so I want to send >> out the patch as soon as possible to see if there is any comments from c= ommunity. >> >> I will include AMD SEV reviewer in this patch series. Thanks for remindi= ng. >> >> Thanks, >> Dun >> >> -----Original Message----- >> From: Yao, Jiewen >> Sent: Friday, October 27, 2023 1:49 PM >> To: devel@edk2.groups.io; Tan, Dun >> Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in >> BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev >> >> HI >> Since this impact TDX and SEV, would you please let me know what kind >> of test you have done? >> Have you validated TDX and SEV before you submit the patch? Please >> describe that clearly in your patch description. >> >> Also please include AMD SEV reviewer in this patch series. >> >> Thank you >> Yao, Jiewen >> >>> -----Original Message----- >>> From: devel@edk2.groups.io On Behalf Of >>> duntan >>> Sent: Friday, October 27, 2023 1:43 PM >>> To: devel@edk2.groups.io >>> Subject: [edk2-devel] [PATCH 0/7] Support Tdx and sev in >>> BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev (Don't merge >>> because the test hasn't been completed yet.) >>> >>> The goal is to have single BaseIoLibIntrinsic instance that can also >>> used for sev and Tdx. >>> In this patch set, string I/O instructions are deleted in IoRead/WriteF= ifo API. >>> Then change the source file of BaseIoLibIntrinsic to also support >>> Tdx and sev feature. So BaseIoLibIntrinsicSev and related assembly >>> code can be >> removed. >>> >>> Dun Tan (7): >>> MdePkg: Create TdxLibNull.inf instance >>> MdePkg: Add CcProbeLibNull and TdxLibNull implement >>> MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c >>> MdePkg:support Tdx and sev in BaseIoLibIntrinsic >>> OvmfPkg: Add CcProbeLib in PlatformInitLib.inf >>> OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files >>> MdePkg:remove BaseIoLibIntrinsicSev related code >>> >>> MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 14 +++= +++++++--- >> - >>> MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 61 >>> ------------------ >>> ------------------------------------------- >>> MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm | 131 ---= -------------- >> --- >>> -------------------------------------------------------------------- >>> -- >>> ---------------------------- >>> ------------- >>> MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm | 293 ---= ------------ >> --- >>> -------------------------------------------------------------------- >>> -- >>> ---------------------------- >>> -------------------------------------------------------------------- >>> -- >>> ---------------------------- >>> -----------------------------------------------------------------------= -------- >>> MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c | 45 >>> +++++++++++++++++++++++++++++++++++++-------- >>> MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h | 166 ---= ------------------- >> -- >>> -------------------------------------------------------------------- >>> -- >>> ---------------------------- >>> -------------------------------------------- >>> MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm | 120 ---= --------------- >> -- >>> -------------------------------------------------------------------- >>> -- >>> ---------------------------- >>> -- >>> MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm | 282 ---= ------------- >> -- >>> -------------------------------------------------------------------- >>> -- >>> ---------------------------- >>> -------------------------------------------------------------------- >>> -- >>> ---------------------------- >>> -------------------------------------------------------------------- >>> MdePkg/Library/TdxLib/TdxLibNull.inf | 21 >>> +++++++++++++++++++++ >>> MdePkg/MdeLibs.dsc.inc | 4 +++= - >>> MdePkg/MdePkg.dsc | 2 +- >>> OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- >>> OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- >>> OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- >>> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- >>> OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 3 ++- >>> OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- >>> OvmfPkg/OvmfPkgIa32.dsc | 2 +- >>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- >>> OvmfPkg/OvmfPkgX64.dsc | 2 +- >>> OvmfPkg/OvmfXen.dsc | 2 +- >>> 21 files changed, 83 insertions(+), 1077 deletions(-) delete mode >>> 100644 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf >>> delete mode 100644 >>> MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm >>> delete mode 100644 >>> MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm >>> delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h >>> delete mode 100644 >>> MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm >>> delete mode 100644 >>> MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm >>> create mode 100644 MdePkg/Library/TdxLib/TdxLibNull.inf >>> >>> -- >>> 2.31.1.windows.1 >>> >>> >>> >>>=20 >>> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110227): https://edk2.groups.io/g/devel/message/110227 Mute This Topic: https://groups.io/mt/102215661/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-