From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 836B681CCC for ; Thu, 3 Nov 2016 16:43:46 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12F13C05678F; Thu, 3 Nov 2016 23:43:48 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-178.phx2.redhat.com [10.3.116.178]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA3Nhkmt002814; Thu, 3 Nov 2016 19:43:47 -0400 To: =?UTF-8?Q?Marvin_H=c3=a4user?= References: <79c821b0-1b1e-e148-e0ae-ee55e83cee48@redhat.com> <147821462919.32367.3606962514472585517@jljusten-ivb> Cc: "edk2-devel@lists.01.org" , "Jordan Justen (Intel address)" From: Laszlo Ersek Message-ID: Date: Fri, 4 Nov 2016 00:43:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 03 Nov 2016 23:43:48 +0000 (UTC) Subject: Re: [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 23:43:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 11/04/16 00:19, Marvin Häuser wrote: > Hey Laszlo, > > I'm quoting Jordan's mail because, for some reason, I didn't receive yours. > Sure, I'm fine with you re-posting the patches, though I thought I considered everything you had said in v3 (not abstracting the size and adding the error message). > Sorry if I didn't consider something, in that case I must have overread it. > > Thanks for 'fixing' the patches! My email is overflowing and I've switched into batched / temporarily write-only mode. I think I got out of sync with you guys. I'll look at your v3 patches soon -- they take priority over my modifications, of course. Thanks Laszlo >> -----Original Message----- >> From: Jordan Justen [mailto:jordan.l.justen@intel.com] >> Sent: Friday, November 4, 2016 12:10 AM >> To: Laszlo Ersek ; Marvin Häuser >> >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] [PATCH v2] OvmfPkg/ResetVector: Depend on PCD >> values of the page tables. >> >> On 2016-11-03 15:55:10, Laszlo Ersek wrote: >>> Hi Marvin, >>> >>> On 11/03/16 20:18, Marvin Häuser wrote: >>>> Currently, the values of the page tables' address and size are >>>> hard-coded in the ResetVector. This patch replaces this with a PCD >>>> dependency for the NASM Reset Vector. The ASM Reset Vector remains >>>> using a hard-coded value due to the lack of C preprocessing. >>>> >>>> Checks for the size have been added to alert the developer to >>>> rewrite the ASM according to the new size, if it has been changed. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Marvin Haeuser >>>> --- >>>> OvmfPkg/ResetVector/Ia32/PageTables64.asm | 23 ++++++++++--------- >> - >>>> OvmfPkg/ResetVector/ResetVector.inf | 5 +++++ >>>> OvmfPkg/ResetVector/ResetVector.nasmb | 7 ++++++ >>>> OvmfPkg/ResetVector/ResetVectorCode.asm | 16 ++++++++++++++ >>>> 4 files changed, 39 insertions(+), 12 deletions(-) >>> >>> I'll soon send a modified / simplified version of your patch (keeping >>> your authorship and S-o-b in the first place of course). I find that >>> simpler than struggling with an explanation :) I hope you're fine with this. >>> >> >> Marvin's v3 seemed okay, but of course, it should be a series, together with >> his separate patch that removes the unused ResetVectorCode.asm file. >> >> If your tweaks are minor, you can add my >> >> Reviewed-by: Jordan Justen >> >> to both of his patches. >> >> Thanks, >> >> -Jordan