Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

["Laszlo Ersek" <lersek@redhat.com>]

On 01/17/20 14:05, Leif Lindholm wrote:
> On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote:
>> On 01/17/20 01:56, Gao, Liming wrote:
>>> Leif:
>>>   .act is same to .aslc. There are no cases in open source. 
>>
>> How about this then:
>>
>> *.[Aa][Cc][Tt]     diff=cpp
>> *.[Aa][Ss][Ll][Cc] diff=cpp
>> *.[CcHh]           diff=cpp
>> *.[Cc][Cc]         diff=cpp
>> *.[Cc][Pp][Pp]     diff=cpp
> 
> To be honest, I would rather just see them all listed explicitly.
> The above actually adds capitalisation-combos not currently listed in
> build_rules.template (like .CpP).

I agree .CpP is non-intuitive, but you previously quoted .Cpp from
"BaseTools/Conf/build_rule.template", which is just as non-intuitive to
me. Who'd *capitalize* a file suffix? (I'd understand *all*-caps.)

So anyway: you suggest to copy the file suffix list verbatim from the
[C-Code-File] and [Acpi-Table-Code-File] sections in
"BaseTools/Conf/build_rule.template". Plus, on top of those, *.h and
*.H. Correct?

Thanks,
Laszlo

> Given how abolutely trivial the fixup for anyone affected would be, I
> think we should also start considering deprecating (with warning) and
> finally retiring file endings not available in any public trees.
> Clearly, that isn't something that needs fixing for this set :)
> 
> Best Regards,
> 
> Leif
>