From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web09.10759.1579284570338911284 for ; Fri, 17 Jan 2020 10:09:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MeD2Z5ti; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579284569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0VtcE5UxqCkMufnRvxzOymPFG88kIfsXSBM8qaTQ0/w=; b=MeD2Z5ti1wDi6OpmBAQuN12yBVOEvdgCQ/ntvLbNW90/Qxcpvd+yUcoeJhZQyPrOqYSKlp qZU1Dt3nGfkvPa9anEJ7QORsT/GF1iLO4jl1J3YwXbdCZAYIx0oL+6zBN3PVKT2Qt/Mcw5 VMldjcWAcAlPseu7yZO9vCAlTzTCMog= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-fwmn0fUWOtC0RZpKjk9YjQ-1; Fri, 17 Jan 2020 13:09:26 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDE178010C0; Fri, 17 Jan 2020 18:09:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-211.ams2.redhat.com [10.36.116.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD1375C1B5; Fri, 17 Jan 2020 18:09:23 +0000 (UTC) Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c To: Leif Lindholm Cc: "Gao, Liming" , "devel@edk2.groups.io" , "Feng, Bob C" References: <20200116184929.18020-1-lersek@redhat.com> <20200116215459.GG20629@bivouac.eciton.net> <428016653b214ab699ec2d6b4ecf2fc9@intel.com> <20200117005102.GJ20629@bivouac.eciton.net> <1529165fc50e49e3abdf073f079c1efd@intel.com> <20200117130548.GK20629@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: Date: Fri, 17 Jan 2020 19:09:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200117130548.GK20629@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: fwmn0fUWOtC0RZpKjk9YjQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 01/17/20 14:05, Leif Lindholm wrote: > On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote: >> On 01/17/20 01:56, Gao, Liming wrote: >>> Leif: >>> .act is same to .aslc. There are no cases in open source. >> >> How about this then: >> >> *.[Aa][Cc][Tt] diff=cpp >> *.[Aa][Ss][Ll][Cc] diff=cpp >> *.[CcHh] diff=cpp >> *.[Cc][Cc] diff=cpp >> *.[Cc][Pp][Pp] diff=cpp > > To be honest, I would rather just see them all listed explicitly. > The above actually adds capitalisation-combos not currently listed in > build_rules.template (like .CpP). I agree .CpP is non-intuitive, but you previously quoted .Cpp from "BaseTools/Conf/build_rule.template", which is just as non-intuitive to me. Who'd *capitalize* a file suffix? (I'd understand *all*-caps.) So anyway: you suggest to copy the file suffix list verbatim from the [C-Code-File] and [Acpi-Table-Code-File] sections in "BaseTools/Conf/build_rule.template". Plus, on top of those, *.h and *.H. Correct? Thanks, Laszlo > Given how abolutely trivial the fixup for anyone affected would be, I > think we should also start considering deprecating (with warning) and > finally retiring file endings not available in any public trees. > Clearly, that isn't something that needs fixing for this set :) > > Best Regards, > > Leif >