public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@ml01.01.org>,
	Feng Tian <feng.tian@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH 2/2] ArmVirtPkg: enable EBC interpreter for AArch64 QEMU
Date: Wed, 17 Aug 2016 15:55:01 +0200	[thread overview]
Message-ID: <a3a9358c-47ec-bf7e-b853-1812dcaa90cc@redhat.com> (raw)
In-Reply-To: <CAKv+Gu9LzRZBCrj4=WzM8Y-wyD6c6Pre+j_m9i9BXmAXiyBUNQ@mail.gmail.com>

On 08/17/16 15:47, Ard Biesheuvel wrote:
> On 17 August 2016 at 15:45, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> Since we now have EBC support for AArch64, enable it by default
>> on the QEMU platform.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> ---
>>  ArmVirtPkg/ArmVirtQemu.dsc           | 1 +
>>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +++++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
>> index 9f88786..fb851e7 100644
>> --- a/ArmVirtPkg/ArmVirtQemu.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
>> @@ -401,3 +401,4 @@ [Components.AARCH64]
>>      <LibraryClasses>
>>        NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
>>    }
>> +  MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> 
> Please add it to ArmVirtPkg/ArmVirtQemuKernel.dsc as well:
> ArmVirtQemuFvMain.fdf.inc is shared between them.
> 
> With that,
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Any reason for not adding it to the Xen platform as well?

What kind of modules do we expect to come in EBC? Option ROMs perhaps?
In that case, Xen may indeed be irrelevant here (I have no clue about
adding oproms to emulated or assigned devices under Xen, so I can't make
an argument either way.) If we expect general stuff (for example, even
UEFI_APPLICATION modules) to arrive in EBC, then I think Xen would be a
justified addition.

Thanks
Laszlo

>> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
>> index ad7037f..0a5b899 100644
>> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
>> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
>> @@ -146,6 +146,11 @@ [FV.FvMain]
>>    #
>>    INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
>>    INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf
>> +
>> +  #
>> +  # EBC support
>> +  #
>> +  INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
>>  !endif
>>
>>    #
>> --
>> 2.1.4
>>



  reply	other threads:[~2016-08-17 13:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17 13:45 [PATCH 0/2] Add EBC support for AArch64 Leif Lindholm
2016-08-17 13:45 ` [PATCH 1/2] MdeModulePkg/EbcDxe: Add AARCH64 EBC VM support Leif Lindholm
2016-08-17 13:46   ` Ard Biesheuvel
2016-08-19  3:12   ` Tian, Feng
2016-08-23  4:33     ` Jordan Justen
2016-08-23  4:57       ` Tian, Feng
2016-08-26 10:56         ` Leif Lindholm
2016-08-17 13:45 ` [PATCH 2/2] ArmVirtPkg: enable EBC interpreter for AArch64 QEMU Leif Lindholm
2016-08-17 13:47   ` Ard Biesheuvel
2016-08-17 13:55     ` Laszlo Ersek [this message]
2016-08-17 14:04       ` Ard Biesheuvel
2016-08-19  1:42         ` Laszlo Ersek
2016-08-17 14:04       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3a9358c-47ec-bf7e-b853-1812dcaa90cc@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox