From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6A7DB1A1DF2 for ; Wed, 17 Aug 2016 06:55:04 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C20AE85376; Wed, 17 Aug 2016 13:55:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-160.phx2.redhat.com [10.3.116.160]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7HDt1bs029971; Wed, 17 Aug 2016 09:55:02 -0400 To: Ard Biesheuvel , Leif Lindholm References: <1471441502-21873-1-git-send-email-leif.lindholm@linaro.org> <1471441502-21873-3-git-send-email-leif.lindholm@linaro.org> Cc: edk2-devel-01 , Feng Tian , Star Zeng From: Laszlo Ersek Message-ID: Date: Wed, 17 Aug 2016 15:55:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 17 Aug 2016 13:55:03 +0000 (UTC) Subject: Re: [PATCH 2/2] ArmVirtPkg: enable EBC interpreter for AArch64 QEMU X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 13:55:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/17/16 15:47, Ard Biesheuvel wrote: > On 17 August 2016 at 15:45, Leif Lindholm wrote: >> Since we now have EBC support for AArch64, enable it by default >> on the QEMU platform. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Leif Lindholm >> --- >> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index 9f88786..fb851e7 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -401,3 +401,4 @@ [Components.AARCH64] >> >> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> + MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > > Please add it to ArmVirtPkg/ArmVirtQemuKernel.dsc as well: > ArmVirtQemuFvMain.fdf.inc is shared between them. > > With that, > > Reviewed-by: Ard Biesheuvel Any reason for not adding it to the Xen platform as well? What kind of modules do we expect to come in EBC? Option ROMs perhaps? In that case, Xen may indeed be irrelevant here (I have no clue about adding oproms to emulated or assigned devices under Xen, so I can't make an argument either way.) If we expect general stuff (for example, even UEFI_APPLICATION modules) to arrive in EBC, then I think Xen would be a justified addition. Thanks Laszlo >> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> index ad7037f..0a5b899 100644 >> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> @@ -146,6 +146,11 @@ [FV.FvMain] >> # >> INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf >> INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf >> + >> + # >> + # EBC support >> + # >> + INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf >> !endif >> >> # >> -- >> 2.1.4 >>