public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ryszard Knop <ryszard.knop@linux.intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	Stephano Cetola <stephano.cetola@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [RFC] Plan to delete ShellBinPkg from edk2/master
Date: Tue, 02 Apr 2019 13:29:56 +0200	[thread overview]
Message-ID: <a3abef3d458619073b7fb9aca1cb65b1921b377b.camel@linux.intel.com> (raw)
In-Reply-To: <20190402091230.zmwcrwb6s55ontm5@bivouac.eciton.net>

On Tue, 2019-04-02 at 10:12 +0100, Leif Lindholm wrote:
> Hi Laszlo,
> 
> On Tue, Apr 02, 2019 at 10:49:16AM +0200, Laszlo Ersek wrote:
> > On 04/02/19 07:38, Bi, Dandan wrote:
> > > Hi All,
> > > 
> > > ShellBinPkg is the remaining binary package in Edk2 repo.  We
> > > plan
> > > to delete ShellBinPkg from edk2/master, and keep source ShellPkg
> > > only in edk2 repo.
> > > Before the deletion, I will update the existing consumers in Edk2
> > > and Edk2Platforms to use ShellPkg directly.
> > > 
> > > If you have any concern please raise here before mid-April . If
> > > there is no concern, I will create patches for this task after
> > > mid-April.
> > > 
> > > Bugzilla for this task:
> > > https://bugzilla.tianocore.org/show_bug.cgi?id=1675
> > 
> > (adding a few CC's)
> > 
> > I think we should not remove ShellBinPkg without a replacement
> > *somehwere*.
> > 
> > A shell binary that is built from a validated edk2 tree, with a set
> > of
> > library resolutions and PCD settings that are known to keep
> > platform
> > dependencies *out* of the shell binary, is extremely useful.
> 
> Agreed. However, I am not sure that accurately describes what we have
> today.
> 
> > IIRC, Andrew suggested earlier that we should treat the shell even
> > as an
> > "OS", with better compatibility standards than we currently
> > maintain.
> > 
> > I think we should only remove ShellBinPkg if we permanently offer a
> > separate download location instead, and we rebuild the shell binary
> > from
> > "ShellPkg/ShellPkg.dsc" at every stable tag.
> 
> I think this sounds like an exellent improvement. When I saw the
> patch, I did immediately think maybe I should start including them in
> my Linaro releases. But if we could automate a build of binaries for
> all supported architectures, and have a place to publish them, that
> would be much better.

One place to put them might be next to the stable releases on GitHub.
Sources are automatically packaged there, binaries can also be
uploaded, also automatically via CI. (Maybe it could also be used to
keep stable OVMF images? Would be nice for quick testing for people not
involved in UEFI development and not having these binaries available in
their OS repos, or having issues with 3rd party builds.)

> Best Regards,
> 
> Leif
> 
> > In that case, removing ShellBinPkg would indeed improve the edk2
> > tree,
> > in my opinion.
> > 
> > Thanks,
> > Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel



  reply	other threads:[~2019-04-02 11:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  5:38 [RFC] Plan to delete ShellBinPkg from edk2/master Bi, Dandan
2019-04-02  8:49 ` Laszlo Ersek
2019-04-02  9:12   ` Leif Lindholm
2019-04-02 11:29     ` Ryszard Knop [this message]
2019-04-02 11:45       ` Laszlo Ersek
2019-04-02 11:50         ` Ryszard Knop
2019-04-02 12:56           ` Laszlo Ersek
2019-04-03  2:17   ` Ni, Ray
2019-04-03 10:09     ` Laszlo Ersek
2019-04-03 15:49       ` Kinney, Michael D
2019-04-03 16:07         ` Laszlo Ersek
2019-04-03 21:47           ` [edk2] " Michael D Kinney
2019-04-04  3:42             ` ray.ni
2019-04-04  4:09               ` [edk2-devel] " Andrew Fish
2019-04-04 10:45                 ` Laszlo Ersek
2019-04-04 15:10                   ` Andrew Fish
2019-04-04 16:06                     ` Laszlo Ersek
2019-04-04 16:36                       ` Andrew Fish
2019-04-08  8:08                         ` Dandan Bi
2019-04-15 14:58                           ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3abef3d458619073b7fb9aca1cb65b1921b377b.camel@linux.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox