public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	Rebecca Cran <rebecca@bluestop.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Daryl McDaniel <edk2-lists@mc2research.org>
Subject: Re: [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers
Date: Tue, 26 Feb 2019 12:56:09 +0100	[thread overview]
Message-ID: <a3af1aac-e3eb-63e1-fe2e-35bf0668a3d2@redhat.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515CBCB8CB11@FMSMSX103.amr.corp.intel.com>

On 02/25/19 22:16, Carsey, Jaben wrote:
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Monday, February 25, 2019 11:41 AM
>> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Daryl McDaniel <edk2-
>> lists@mc2research.org>
>> Subject: Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's public
>> DNS servers
>> Importance: High
>>
>> On 02/25/19 19:36, Rebecca Cran via edk2-devel wrote:
>>> The current servers listed appear to be unusable. I suspect most
>>> people will get correct DNS servers via DHCP, but the defaults
>>> should work for anyone.
>>>
>>> Change the entries to be Google's public DNS servers.
>>> Also, change the domain name to be example.com, to be more applicable
>>> to consumers outside Intel.
>>> ---
>>>  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf
>> b/StdLib/Efi/StdLib/etc/resolv.conf
>>> index 3ac16ac230..724e6297b2 100644
>>> --- a/StdLib/Efi/StdLib/etc/resolv.conf
>>> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
>>> @@ -1,13 +1,13 @@
>>>  #
>>>  #   Domain name
>>>  #
>>> -domain          intel.com
>>> +domain          example.com
>>>
>>>  ;
>>>  ;   Name Servers
>>>  ;
>>> -nameserver      206.63.63.61
>>> -nameserver      216.251.100.1
>>> +nameserver      8.8.8.8
>>> +nameserver      8.8.4.4
>>>
>>>  ; nameserver      10.248.2.1
>>>  ; nameserver      10.22.224.204
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>> I'm quite undecided, but I vaguely feel that this should be pushed only
>> after we tag "edk2-stable201903". The domain name change doesn't look
>> like a pure bugfix, especially for Intel associates. Opinions?
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> 
> I have no strong opinion on timing.

OK, let's delay this one. I'll keep it tagged.

Thanks,
Laszlo


  reply	other threads:[~2019-02-26 11:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 18:36 [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers Rebecca Cran
2019-02-25 19:41 ` Laszlo Ersek
2019-02-25 21:16   ` Carsey, Jaben
2019-02-26 11:56     ` Laszlo Ersek [this message]
2019-02-26 12:31 ` Laszlo Ersek
2019-03-08  2:15   ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3af1aac-e3eb-63e1-fe2e-35bf0668a3d2@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox