From: Ming Huang <ming.huang@linaro.org>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"linaro-uefi@lists.linaro.org" <linaro-uefi@lists.linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Zeng, Star" <star.zeng@intel.com>,
"Dong, Eric" <eric.dong@intel.com>
Cc: "huangming23@huawei.com" <huangming23@huawei.com>,
"zhangjinsong2@huawei.com" <zhangjinsong2@huawei.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"waip23@126.com" <waip23@126.com>,
"wanghuiqiang@huawei.com" <wanghuiqiang@huawei.com>,
"huangdaode@hisilicon.com" <huangdaode@hisilicon.com>
Subject: Re: [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue
Date: Fri, 28 Sep 2018 14:18:04 +0800 [thread overview]
Message-ID: <a3beeae5-bb45-4202-ae79-af031fd92db5@linaro.org> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BE4E5E4@SHSMSX104.ccr.corp.intel.com>
On 9/26/2018 1:00 PM, Ni, Ruiyu wrote:
>> @@ -507,12 +552,13 @@ BmRepairAllControllers (
>> FormBrowser2,
>> &HiiHandles[Index],
>> 1,
>> - PcdGetPtr (PcdDriverHealthConfigureForm),
>> + &gEfiHiiDriverHealthFormsetGuid,
>
> I still don't quite understand the changes.
> But the above specific change removes the PcdDriverHealthConfigureForm form pop up.
> Instead it pops up each driver health form one by one.
> Why?
This change is refer to the below function:
ProcessSingleControllerHealth (IntelFrameworkModulePkg/Universal/Bdsdxe/DeviceMngr/DeviceManager.c).
I don't real understand it also, but it works.
>
>> 0,
>> NULL,
>> NULL
>> );
>> if (!EFI_ERROR (Status)) {
>> + ShowConfigureForm (FormBrowser2,
>> + InfoConfigurationRequired);
>> break;
>> }
>> }
>> --
>> 2.18.0
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-09-28 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 6:36 [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] Fix raid card repair fail issue Ming Huang
2018-09-15 6:36 ` [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: " Ming Huang
2018-09-18 9:40 ` Ni, Ruiyu
2018-09-19 2:10 ` Ming Huang
2018-09-26 5:00 ` Ni, Ruiyu
2018-09-28 6:18 ` Ming Huang [this message]
2018-10-08 6:39 ` Ni, Ruiyu
2018-10-08 12:15 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2018-09-15 6:33 [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] " Ming Huang
2018-09-15 6:33 ` [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: " Ming Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3beeae5-bb45-4202-ae79-af031fd92db5@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox