From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::530; helo=mail-pg1-x530.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 577282112870A for ; Thu, 27 Sep 2018 23:18:23 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id z3-v6so3662340pgv.8 for ; Thu, 27 Sep 2018 23:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YvYASt67+ybrOhSe9F7jgQuQH1G2ZRvivUFfObl3Koo=; b=OEOSZXlOGUIvPjDFU35jaXmW2ATW8f6W9EPg+/MkaX327eoNVKtDBPUQZQwqB0xZj1 /1JrO0Ak4NjgPFU3VWAQUP3KLlI60D8VYF7Su0jjcxTYEFE3XU361ORfICzQsea55Au0 4akQsyqqGik/Kctuy3Y9Wi+37c9b/JjGN26U0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YvYASt67+ybrOhSe9F7jgQuQH1G2ZRvivUFfObl3Koo=; b=ZZMofrVfS3ZnezHiPOi2Ree+6/3aoYIDfKMIo1+E9p+9qFjgwITuyQJzPT0qjgCD1/ gikDAAH8UtYRjqSR/QOiXt9dwCjh3zIn1Hww1gQ9RJ+jCevb1eOjsT/eDSKtPCuPZaos fak936JojFdeHFnewL9CmTXibxJzZmYHfTb9aABRKXNG3gi1T8BqRMcn0Vi4L84elDaa w5aG9aXcAlQ/S1vJv+FWVjZnggRVb5r4fnsT0jR1orLlbSDPEXVmtORQisGDccHtnCis oKDf9pjXKw3t/sfz5Zfd904QDItcRzBZH20cmg0ogdQACrzcjI0FrJ7GITEsVmF+/ZoB RraA== X-Gm-Message-State: ABuFfog7EzHwMhOWIrZbMIiOEpMDbQaQKuTrHVPnR3Thl0/6vS/QjuSi DYeVq8lxLzpsIXzaGrLs0feWuQ== X-Google-Smtp-Source: ACcGV61/y6bWF33THg8R4KjpAyQgIDJeGQXFo2JdqQBU2+RpnIkB1w6vhNF9lokP/IBHSIAZiMOZkA== X-Received: by 2002:a63:7e1c:: with SMTP id z28-v6mr13383004pgc.246.1538115502635; Thu, 27 Sep 2018 23:18:22 -0700 (PDT) Received: from [10.69.0.86] ([64.64.108.185]) by smtp.gmail.com with ESMTPSA id 5-v6sm11024510pgt.83.2018.09.27.23.18.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Sep 2018 23:18:21 -0700 (PDT) To: "Ni, Ruiyu" , "linaro-uefi@lists.linaro.org" , "edk2-devel@lists.01.org" , "Zeng, Star" , "Dong, Eric" Cc: "huangming23@huawei.com" , "zhangjinsong2@huawei.com" , "Gao, Liming" , "Kinney, Michael D" , "waip23@126.com" , "wanghuiqiang@huawei.com" , "huangdaode@hisilicon.com" References: <20180915063656.6250-1-ming.huang@linaro.org> <20180915063656.6250-2-ming.huang@linaro.org> <734D49CCEBEEF84792F5B80ED585239D5BE4E5E4@SHSMSX104.ccr.corp.intel.com> From: Ming Huang Message-ID: Date: Fri, 28 Sep 2018 14:18:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BE4E5E4@SHSMSX104.ccr.corp.intel.com> Subject: Re: [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 06:18:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/26/2018 1:00 PM, Ni, Ruiyu wrote: >> @@ -507,12 +552,13 @@ BmRepairAllControllers ( >> FormBrowser2, >> &HiiHandles[Index], >> 1, >> - PcdGetPtr (PcdDriverHealthConfigureForm), >> + &gEfiHiiDriverHealthFormsetGuid, > > I still don't quite understand the changes. > But the above specific change removes the PcdDriverHealthConfigureForm form pop up. > Instead it pops up each driver health form one by one. > Why? This change is refer to the below function: ProcessSingleControllerHealth (IntelFrameworkModulePkg/Universal/Bdsdxe/DeviceMngr/DeviceManager.c). I don't real understand it also, but it works. > >> 0, >> NULL, >> NULL >> ); >> if (!EFI_ERROR (Status)) { >> + ShowConfigureForm (FormBrowser2, >> + InfoConfigurationRequired); >> break; >> } >> } >> -- >> 2.18.0 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel