From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.10915.1585314381719228104 for ; Fri, 27 Mar 2020 06:06:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=hWVzi8Pq; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.66, mailfrom: pete@akeo.ie) Received: by mail-wr1-f66.google.com with SMTP id 31so11325603wrs.3 for ; Fri, 27 Mar 2020 06:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2ZbXeOgPibtDsxLxJQXSNGbH3bk/B4aSWIcoJlIo690=; b=hWVzi8Pqlfj97ajJiK5NhTz7WL+YLIlAZbZeUKPFIDwOq5ncjg+bA49ujszEcUUCS6 ijySSIEVfgyoUgbQfse5rRw2T4PcalxrNFKMBOvLhaG+bSRr+MrfYR2+pJfRNpLqik8k xoJPlCJfH7J0Vx93vpIkVA2EuI6VoFteE4JQR8o1b0MT2QhUvKnt1ZwTt4ms27YqQG2F hEsBW5UEKNRdb4cQJCon6t1Z/23ABnO4uGyQtw9Jw3xKqj4a6o97HDWj14jh+z3YWhbq ZwZSyywIoygFj44fy069vh8ORQStBYA2ZlBNW4ucsk+YjNATZEMyx1ct9iICJqOGQwiN QB5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2ZbXeOgPibtDsxLxJQXSNGbH3bk/B4aSWIcoJlIo690=; b=QXw7W1jxpZnE5TqOPp+3YXO1ydKu3IL+tfNRm/fGwwQSmw1OQJ8MX3+ZdOrQZsox89 tIKlcHX5wIQD3MUtk0OHfUn3wLXjk5BOQZ1XhkyYQ9aiXXVxDPt3UxPfdKupgr6LMLYi 8rRefvVwAl2xtPe+x+x7iSoRiIUiZ2Z5Gyp+n64DzF4FP6j329/e9EmDZRV3RaSI4vNI VFrWQzaaOwH9pYuwpla43Pq5NfG/e/HD6eoSdl22q1e8nQF28tzwsOGdO4eMaHsYfdw5 18wNwCqfpsF1edZd0niHA5V8B+MecESIa++oacmaHSCtLxPcGV8YREo0gLuE77O3onY1 zl3A== X-Gm-Message-State: ANhLgQ3JfaNZmwI1kDvXgYNWo8M9rUhuPuPLXVQ2jvJvnp/Rvtp/CXAi znG/RF+8J0LW8bZSa5+LnRYOSg== X-Google-Smtp-Source: ADFU+vvBggN7AQBP2SNSghtkxtRMM1xAKHbSdVw0+HruPTtiDOKCDE5oUzErsIDddtHVD+lePjLw9A== X-Received: by 2002:a5d:6a10:: with SMTP id m16mr9046108wru.371.1585314380309; Fri, 27 Mar 2020 06:06:20 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.78.33]) by smtp.googlemail.com with ESMTPSA id a82sm14590248wmh.0.2020.03.27.06.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2020 06:06:19 -0700 (PDT) Subject: Re: [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3 From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif@nuviainc.com References: <20200327130117.11304-1-pete@akeo.ie> Message-ID: Date: Fri, 27 Mar 2020 13:06:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200327130117.11304-1-pete@akeo.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Incidentally, this is not an [edk2-platform] patch, as the subject line from previous mail seemed to indicate, but an [edk2] patch. /Pete On 2020.03.27 13:01, Pete Batard wrote: > ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing > 2 of the 3 reserved bytes that are defined at the end of the > GICC structure for 6.0. > > Add a new macro to initialise the new field. > > Signed-off-by: Pete Batard > --- > EmbeddedPkg/Include/Library/AcpiLib.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h b/EmbeddedPkg/Include/Library/AcpiLib.h > index 5c6e2075de79..57d7bd595584 100644 > --- a/EmbeddedPkg/Include/Library/AcpiLib.h > +++ b/EmbeddedPkg/Include/Library/AcpiLib.h > @@ -64,6 +64,14 @@ > {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE} \ > } > > +#define EFI_ACPI_6_3_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags, PmuIrq, \ > + GicBase, GicVBase, GicHBase, GsivId, GicRBase, Efficiency, SpeOvflIrq) \ > + { \ > + EFI_ACPI_6_0_GIC, sizeof (EFI_ACPI_6_0_GIC_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ > + GicId, AcpiCpuUid, Flags, 0, PmuIrq, 0, GicBase, GicVBase, GicHBase, \ > + GsivId, GicRBase, Mpidr, Efficiency, EFI_ACPI_RESERVED_BYTE, SpeOvflIrq \ > + } > + > #define EFI_ACPI_6_0_GIC_MSI_FRAME_INIT(GicMsiFrameId, PhysicalBaseAddress, Flags, SPICount, SPIBase) \ > { \ > EFI_ACPI_6_0_GIC_MSI_FRAME, sizeof (EFI_ACPI_6_0_GIC_MSI_FRAME_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ >