From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.52]) by mx.groups.io with SMTP id smtpd.web12.20777.1621265667287587186 for ; Mon, 17 May 2021 08:34:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Fu+AaJMj; spf=pass (domain: arm.com, ip: 40.107.22.52, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dPLrFej4petU5CMzp3mCt1fg5J30B75pMOCwdctJVLQ=; b=Fu+AaJMjiZCgaru24/iUbjR8O4aZZTYXqaz3HuwwZf0Aue8y/IOqqAl36Ezq4Sb0vcJCqY4umj1HIC1Aw43LCRIQULEgZVlGv0mrq/ZX3oLrlySFfNaYGui7GhK3DxkYtL474xKDvEZmPsFqZpQhPg17JAe28ZmOcuYi4WLZI8o= Received: from DB6PR07CA0077.eurprd07.prod.outlook.com (2603:10a6:6:2b::15) by DBBPR08MB4886.eurprd08.prod.outlook.com (2603:10a6:10:f4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Mon, 17 May 2021 15:34:22 +0000 Received: from DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2b:cafe::f4) by DB6PR07CA0077.outlook.office365.com (2603:10a6:6:2b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Mon, 17 May 2021 15:34:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT041.mail.protection.outlook.com (10.152.21.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 17 May 2021 15:34:22 +0000 Received: ("Tessian outbound 3c287b285c95:v92"); Mon, 17 May 2021 15:34:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cc45b24f4e0644ab X-CR-MTA-TID: 64aa7808 Received: from 38f6f40e5833.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 53FEEB21-240C-473B-A37E-46F263E92D2C.1; Mon, 17 May 2021 15:33:55 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 38f6f40e5833.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 May 2021 15:33:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VO3HmTB/mGHtKoHTS8z5ejtX25Oywm6MkMDoPtRv45srTEme4P0DIh8/YP+5cAoJguB8m7V5XS/SVJ59L+9a9jNcr+LrN98NU2PNa545Jmb8bYyJ2qfMbLOQtDBpwd6Zd9IuFk6mdSkOZqC59m/Sh3KxX9z5d/iDrsbxVPobIhwyRQiOb2K5v/J4F2/lb9eANSBq/bzVivJjN2ThCDx+j7r3/YO9Ycxu2sBglcuMOIr85JNr1Mage7iZFUTBsT015WLUKfmmV/Tnr7BmjAoJuXTvlQuxxN2tR9gAAfacMZDVnPZFlazSNmhJ0JXN1IsXE4NTZeK4Bp/BJ0yki1LVKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dPLrFej4petU5CMzp3mCt1fg5J30B75pMOCwdctJVLQ=; b=TIFwSEcv5h0zx5fl2uwSYXKysyMuvsdHfZtyXI9Iq5AYvXIzrGGxIjsr7zjDcLswMw2GVetC6t8+EDtq097XBQzBnWKZZkOl4a7zzLGCzQox8wxeT1i26bQacrKTBi+h8UYfke1juAy8ayZtxS+gdkgF1k3a1QyK69JDesASsdlcgkJL3dn8xSAX4XVx0mSh15t682rOG7698EoPEK9zQuSRXHkbgFaTGSvnusM0IvaKk2KEpGP8Br2tlNZk6nyyt5kJJK0GHLAIHQe1I/m3oWslWXn5W1dVCo+hSD3g86a9FhnmoFV4Jksvs63BIY79DUjtJPTXgOfMv698AqxH2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dPLrFej4petU5CMzp3mCt1fg5J30B75pMOCwdctJVLQ=; b=Fu+AaJMjiZCgaru24/iUbjR8O4aZZTYXqaz3HuwwZf0Aue8y/IOqqAl36Ezq4Sb0vcJCqY4umj1HIC1Aw43LCRIQULEgZVlGv0mrq/ZX3oLrlySFfNaYGui7GhK3DxkYtL474xKDvEZmPsFqZpQhPg17JAe28ZmOcuYi4WLZI8o= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6008.eurprd08.prod.outlook.com (2603:10a6:20b:29d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Mon, 17 May 2021 15:33:52 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4129.031; Mon, 17 May 2021 15:33:52 +0000 Subject: Re: [edk2-platforms][PATCH V2 10/11] Platform/Sgi: Add SMBIOS Type19 Table To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel , nd@arm.com References: <20210516092917.21124-1-pranav.madhu@arm.com> <20210516092917.21124-11-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: Date: Mon, 17 May 2021 16:33:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210516092917.21124-11-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO2P123CA0108.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO2P123CA0108.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 17 May 2021 15:33:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4afe8508-443d-4adc-5e22-08d919493ec6 X-MS-TrafficTypeDiagnostic: AS8PR08MB6008:|DBBPR08MB4886: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5516;OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RfUmjKrb5lQTgBxoCARQ2+7xdD+45k3nCwjPHJ3eXMGHO3bBFb6yAUgNWZdi2w+RWGXTLfVvjRIQf36LQXKjz+s9eyshRC88di43i1duI2TGnF5vrYMynazQYRHxLnGw2TH5e3ICJqKD7hXevBVtcdaWJmpMTc+uOclW4NrVEtcyyi1pFVB7jxc6m/JekVoFiktmUIBXP/lkxSSsToM6pV0NiCJXcu41miXKUDFKjpkspZoNYjzB3gb9Pcv0dSZb/tB1u0SDwVFaCD85cMIXxUDdOSM3XXNWmlahASGVm8qUBhPq3CCYIgBgq3QybTol7r54q9CXMLBjrpLae4NtIumdkCPey+DqZof2mZ7+0LBo/ITH8qdD9SD6wymQBQuxx8FcjNKHgUBiERFnFa+cpUJWtYFUCWs6t6ihz17L4upKS+7HyNh0INYritH4Yc21/Ih7z4T46glrUb+tUx7vmY5LdOPvPr5ksy8leXgTqKUNTGCRbVkhLBpAhLHvSnxdm28RKB+Ngl8IaRKl/upFPvSbxUGX2dgZHaq1u0g0S9/RbdvwxUyWk9e5mKKRQQg09Axp1hF19P3WNZspBi1dtmcMdNHVfW+F+YPHH51qpSXgIu0HhMAJcfEhox3dQP83wZyVrC8sw6banOxg3TgX5oR6XfUrR9WPHyatkIWLs6y/RuFDZOl+aHTROSsWi+RrIzNuhmQHM+vDcm2PU03jZ64Mpitjq3J1H61ZziU92yE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(346002)(366004)(376002)(396003)(136003)(2906002)(5660300002)(38100700002)(38350700002)(19627235002)(6486002)(16526019)(36756003)(83380400001)(66476007)(66556008)(31696002)(66946007)(52116002)(4326008)(316002)(16576012)(44832011)(956004)(2616005)(31686004)(8676002)(86362001)(186003)(53546011)(26005)(8936002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eVBmcEk5K1NTdUtXazhpeXVrRFBnRTEyVTZleUlDWmtQMTQvcVVUUlM4THJu?= =?utf-8?B?ZGFFTEJtWUVGb0lkS0JrRE52S1g5UTd2UVhVWEJsa3piUlhzV2ZtL21BT3h6?= =?utf-8?B?MDIwb3dZZ3FIdFh4KzRXTFg4OGN5VkQ5SnJXZ0N2WGRuM0xvOUtyNUxrQTVH?= =?utf-8?B?QkFFcVhPb082OThUdUdxbzBpSHd2bHNPWEcvVmpHRDNUMXNzOHptS2JiOUNW?= =?utf-8?B?M0xEUC8xM2g0b1F2VGZaYWZ0R1IyS3ZOWlVqMFY0bzRBRDZaZlJEUE8zQnFD?= =?utf-8?B?Y0o0eDBmKzEzbTVUaVI2TkRpb016QlFBUWxTc0MzQmZqNkYzNmt2L3o4TmFC?= =?utf-8?B?SUhzL3l5YnRFaWxYaEZhVzl6MUR1WUtvcDgySUxuOCtGZHlSNFBmUk5lMkgx?= =?utf-8?B?c1NUeVhlQnhPWVMvdjg2dXBXNTNrNXk0VGltVnZVc2JwVGRoZWdSY3ZSaFUw?= =?utf-8?B?THlKUVlQSUJUY2llMG1YN3o3TGlTQUN6eFZhTjBXbDlKT21abXkxckVtZVY3?= =?utf-8?B?aEN3SHFiWmUyVUZ5YXFVZkp3aGc2djVLRzUyU2VDWE9UZ0tYRG9BajJSZjZl?= =?utf-8?B?M1VNSVk0RTQzZ2FlaEsyL2RRMU9xaXYvaTFaUG8vRlRZSGxUQkFiRnFIeVFO?= =?utf-8?B?dFZ0aU9UMlhzQkx0ZDU4bFd6VDRSemNlNmtJSzBSQXZUTWJVQW1kUlY1c2ZW?= =?utf-8?B?WWNHd3hISWN5VUxxWUFJbXFCM2JZZ2h1YWJ3d1dWK1Vlb0VTT3VUczFkekZL?= =?utf-8?B?ZlZDUk5HdFhUaHptUGJmQ2lEbEJhakZxa1BIejdCbVoyWWdMc1dlMVc2dFdw?= =?utf-8?B?OW5oR1YxNml3VTNBYTBTZlZheXRKUkJoQ09Fb1E0M0NRWGtSUDhNRE95RjI4?= =?utf-8?B?b1UvZC9BWmVWNjZZbFJGUXhMc2RDTEh6Q0ZWOFNEWWU2azcxeEU0aTd3dCtZ?= =?utf-8?B?M3Z5WU1jNjNGWmVhZzUvaWREdGV0V2FwTlZSVW5RRHBnZFZKRDFvRHAxbVAy?= =?utf-8?B?UFo3Wk5DMXNta0VrM3dLUE5oTHk5NWZ6eExhK3Njc1kvTjBmdy9udEpoRlFw?= =?utf-8?B?VXB4L1BtcHJ4M1dqUzZMaDhvMi9wU1hWSWs5UkRFdTQrenEzZWNNQnhPY3Qv?= =?utf-8?B?WFF3QkdVYmwwVGtaT1FvS3F5T29jL0NLMmxUM1h6blVFaEdGbmRsaXRSUFFH?= =?utf-8?B?U1l1WWtZY2VDeXNVQkdXUm5hR0swaC92bElMME91eVdYSEJsQ2x1T0V0SHg2?= =?utf-8?B?K1plVUlMaEpkUmlFa2tVd3dNWkxvSnE5eGs0elZ3cklVaTJwZ2ZpcXQ0NTZp?= =?utf-8?B?bnAvK0NjTXNyZFl1QllrWWNDV2ZDR1UvSkZ5eWQyZEU3UUNuUDY5bDhGSXhV?= =?utf-8?B?L1dPUWg3VGdma2pIeGhMbnBOemNrdmJrd0JQeGw5ZU41Y0ZsTEhpQ2diVlRH?= =?utf-8?B?RGp3N1E5Z3lyWExMVFp3c0V3d0tlNEJUVm5MdnE5dHFFNHN5bjk0ZmNzT0Vh?= =?utf-8?B?YXNQY3luVHM2bEdvZzBqbVVMUVlWd3FWMDMzMXgwYjlSU3ZtNG82cEN3blZ3?= =?utf-8?B?dHNGSC9CMHczMkplNnBYZ0svY1BINzZtYzVCSDNRdXI5VEQ1M3RMV2F3VUFB?= =?utf-8?B?aE91Vm52TFdVUlVxb3dIb01IZHZXcCtaWm1VTTl6cjZCRFdtSGYvbjFQWS9v?= =?utf-8?B?ZUpMNGZ2ZWdKMjhGRlphRndJSTV4U0xhYzRZc1NsSzNxZ1QzZUNPUkJMNjl3?= =?utf-8?Q?qN40m2bJMXG8uwMaNJEqf6vNyGJ97MpS2ZDSYR7?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6008 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7c66c2b7-a04d-4c75-0244-08d919492ccf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3pvZnT/lyYf5Si7UCW5OmqWQ2pJSPQBL5r3vXHI/iXKI+4COqLFQR43M45j63iRzGV64zJO5+bPLOCSDayipsZrwcktb4KRJk5/HFeTN170GI3F/VRWpDrh//pRtuOm0vzniwOOP8eb+3IdxyYJmxg8sLsUhEQS0yrYiiwzNbfiEKP95tziwp/UYokO004vc2rA7IGYjSlzMMfT8vDh6zZgmgZcldMlGIJQg/J+2jMO7QAlrszPGGFro8Z3u6Vm4hUUKuONwu0YfB/HJ8UwutP6xu1J8SXrdIHLJ/KKdpeH9kUIDj1AR0dGOFzHsvlD3++6agZF8qRCsY+J1SYtJdRTh45VsDY8q50pLW3jMrtYO7k1mNh4Tby5xAEFqEPxuixtC/BggbKF1MESOeSd6mLnhv4mZuBYj60jtGM6rhlmrmyv4wK2vm57KH4zzwFcalhx8udtfb3t1DKyAcjb2+Ywn3DNm65NoNRCKdlrHQPdTrqUFVn4lMmB9HJtDbb2PzcrGkdcn25FGWryQgcQek9qobk5L9haAHcRXs8LxHGoEmDkZlvcwC1FemA0LYIzEEX0omjtq3BwQv+0+15VpOJq1fWzL+6YRvKcg2XBxQB0v/BpVDbeJSRzCNuo/9fqBL70JNbZ11coVdNTzqLaJp3IMa3eLVz56bu4wCO0193nVNyjS1PA/Iu06PC9oo9Jl X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(396003)(376002)(346002)(136003)(36840700001)(46966006)(36756003)(2616005)(70586007)(4326008)(336012)(6486002)(53546011)(31686004)(82310400003)(956004)(82740400003)(8936002)(26005)(70206006)(356005)(81166007)(47076005)(8676002)(31696002)(5660300002)(478600001)(16576012)(83380400001)(186003)(44832011)(36860700001)(316002)(86362001)(19627235002)(2906002)(16526019)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2021 15:34:22.5890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4afe8508-443d-4adc-5e22-08d919493ec6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4886 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pranav, Please find my comments inline marked [SAMI]. Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: > Add the SMBIOS type 19 table (Memory Array Mapped Addr) that includes > information about the address mapping for a Physical Memory Array. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 6 ++ > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c | 92 ++++++++++++++++++++ > 4 files changed, 100 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > index 9061c491d461..f81494114188 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > @@ -22,6 +22,7 @@ > Type7CacheInformation.c > Type16PhysicalMemoryArray.c > Type17MemoryDevice.c > + Type19MemoryArrayMappedAddress.c > > [Packages] > ArmPkg/ArmPkg.dec > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > index 5413982e233b..c6dd72cb6b99 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > @@ -53,6 +53,12 @@ InstallMemoryDevice ( > IN EFI_SMBIOS_PROTOCOL *Smbios > ); > > +EFI_STATUS > +EFIAPI > +InstallMemoryArrayMappedAddress ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ); > + > enum SMBIOS_REFRENCE_HANDLES { > SMBIOS_HANDLE_ENCLOSURE = 0x1000, > SMBIOS_HANDLE_CLUSTER1, > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index 223bf1d114e4..d5d1e6393184 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -33,6 +33,7 @@ ARM_RD_SMBIOS_TABLE_INSTALL_FPTR mSmbiosTableList[] = { > &InstallCacheInformation, > &InstallPhysicalMemoryArray, > &InstallMemoryDevice, > + &InstallMemoryArrayMappedAddress, > }; > > /** > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c > new file mode 100644 > index 000000000000..de458ab29e68 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c > @@ -0,0 +1,92 @@ > +/** @file > + SMBIOS Type 19 (Memory Array Mapped Address) table for ARM RD platforms. > + > + This file installs SMBIOS Type 19 (Memory Array Mapped Address) table for Arm's > + Reference Design platforms. It includes information about the address mapping > + for a Physical Memory Array. > + > + Copyright (c) 2021, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Specification Reference: > + - SMBIOS Reference Specification 3.4.0, Chapter 7.20 > +**/ > + > +#include > +#include > +#include > + > +#include "SmbiosPlatformDxe.h" > + > +#define TYPE19_STRINGS \ > + "\0" /* Null string */ > + > +/* SMBIOS Type19 structure */ > +#pragma pack(1) > +struct ArmRdSmbiosType19 { > + SMBIOS_TABLE_TYPE19 Base; > + UINT8 Strings[sizeof (TYPE19_STRINGS)]; > +}; > +#pragma pack() > + > +/* Memory Array Mapped Address */ > +static struct ArmRdSmbiosType19 mArmRdSmbiosType19 = { > + { > + { > + // SMBIOS header > + EFI_SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS, // Type 19 > + sizeof (SMBIOS_TABLE_TYPE19), // Length > + SMBIOS_HANDLE_PI_RESERVED, // Assign an unused handle number > + }, > + 0, // Starting address > + 0, // Ending address > + SMBIOS_HANDLE_PHYSICAL_MEMORY, // Memory array handle > + 1 // Partition width > + }, > + // Text strings (unformatted area) > + TYPE19_STRINGS > +}; > + > +/** > + Install SMBIOS memory array mapped address table > + > + Install the SMBIOS memory array mapped address (type 19) table for RD > + platforms. > + > + @param[in] Smbios SMBIOS protocol. > + > + @retval EFI_SUCCESS Record was added. > + @retval EFI_OUT_OF_RESOURCES Record was not added. > + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in is already in use. > +**/ > +EFI_STATUS > +InstallMemoryArrayMappedAddress ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ) > +{ > + EFI_STATUS Status; > + EFI_SMBIOS_HANDLE SmbiosHandle; > + > + SmbiosHandle = ((EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType19)->Handle; > + > + mArmRdSmbiosType19.Base.StartingAddress = PcdGet64 (PcdSystemMemoryBase) / SIZE_1KB; > + mArmRdSmbiosType19.Base.EndingAddress = ((PcdGet64 (PcdSystemMemoryBase) + > + (PcdGet64 (PcdSystemMemorySize) + SIZE_16MB)) / // 16MB Trusted DRAM > + SIZE_1KB) - 1; [SAMI] Same comment as for patch 9/11. Can you atleast add some validation to ensure that the encoding would be correct, please? [/SAMI] > + > + /* Install type 19 table */ > + Status = Smbios->Add ( > + Smbios, > + NULL, > + &SmbiosHandle, > + (EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType19 > + ); > + if (Status != EFI_SUCCESS) { > + DEBUG (( > + DEBUG_ERROR, > + "SMBIOS: Failed to install Type19 SMBIOS table.\n" > + )); > + } > + > + return Status; > +}