Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

[Laszlo Ersek]

On 04/29/20 23:53, Rebecca Cran wrote:
> Generated mechanically with:
> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

[Laszlo Ersek]

(+Sean, Mike, Michael)

On 04/30/20 14:51, Laszlo Ersek wrote:
> On 04/29/20 23:53, Rebecca Cran wrote:
>> Generated mechanically with:
>> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 

Submitted this patch for merging in
<https://github.com/tianocore/edk2/pull/569>.

The CI run failed with the following error:

"Unhandled: Not found SourceFolder:
/home/vsts/work/1/s/BaseTools/BaseToolsBuild"

https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226650
https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226688
https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226957

I don't know what to do about that.

Thanks
Laszlo

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

[Laszlo Ersek]

On 04/30/20 15:04, Laszlo Ersek wrote:
> (+Sean, Mike, Michael)
> 
> On 04/30/20 14:51, Laszlo Ersek wrote:
>> On 04/29/20 23:53, Rebecca Cran wrote:
>>> Generated mechanically with:
>>> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>>>
>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
> 
> Submitted this patch for merging in
> <https://github.com/tianocore/edk2/pull/569>.
> 
> The CI run failed with the following error:
> 
> "Unhandled: Not found SourceFolder:
> /home/vsts/work/1/s/BaseTools/BaseToolsBuild"
> 
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226650
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226688
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226957
> 
> I don't know what to do about that.

Now that I've looked again, the PR has been merged.

I don't understand why those errors were raised -- but now I also don't
understand why the PR was merged in spite of errors (of any kind).

Anyway, I'll run with the result: commit 70d5086c3274.

Thanks
Laszlo

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

[Rebecca Cran]

On 4/29/20 3:53 PM, Rebecca Cran wrote:

> Generated mechanically with:
> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;

Could I get a review on this please?


-- 
Rebecca Cran

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

[Laszlo Ersek]

Hi Rebecca,

On 05/10/20 02:14, Rebecca Cran wrote:
> On 4/29/20 3:53 PM, Rebecca Cran wrote:
>
>> Generated mechanically with:
>> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>
> Could I get a review on this please?

I both reviewed and merged this patch already, on April 30th; one day
after you posted the patch. Please see my related messages on the list
(also addressed to you personally):

(1) review:

https://edk2.groups.io/g/devel/message/58433
http://mid.mail-archive.com/aee69f0a-1094-26fe-a81e-441e1a2c49d9@redhat.com

(2) merge:

https://edk2.groups.io/g/devel/message/58436
http://mid.mail-archive.com/1ebde38a-7ae4-1bed-cbe6-b44b0e8dbab5@redhat.com

It is commit 70d5086c3274.

Thanks,
Laszlo